You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/25 09:48:46 UTC

[GitHub] tzulitai opened a new pull request #7821: [FLINK-11741]

tzulitai opened a new pull request #7821: [FLINK-11741] 
URL: https://github.com/apache/flink/pull/7821
 
 
   ## What is the purpose of the change
   
   This commit is based on top of #7818. The first commit is not relevant.
   
   All remaining implementations of the deprecated `TypeSerializer#ensureCompatibility` method should be removed.
   
   Some implementations previously may not have been removed yet while upgrading the serializers because of various limitations causing the old snapshot class not being able to redirect schema compatibility checks to new snapshot class (e.g. the old snapshot class was shared across serializers).
   
   These problems should be addressable now with the auxiliary `SelfResolvingTypeSerializer` / `LegacySerializerSnapshotTransformer` interfaces.
   
   ## Brief change log
   
   - 24d87d6: Simple quality-of-life addition to the legacy `CompositeTypeSerializerConfigSnapshot` class, to return just an array of the nested serializer snapshots.
   - 68c0b9e to f3d0641: Remove `ensureCompatibility` implementations, where the re-direction of schema compatibility check can be resolved using the `SelfResolvingTypeSerializer` interface.
   - 46835ca to ae51e8e: More complicated redirections that require the legacy snapshot to be reprocessed, using the `LegacySerializerSnapshotTransformer` interface.
   - 9cb8af6: Simple fixup to the `WritableSerializer` which was recently upgraded.
   - 8e4f02c to 88e6f8b: Removal of `ensureCompatibility` implementations in dummy serializers and test serializers.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   This change is already covered by subclasses of `TypeSerializerSnapshotMigrationTestBase`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **yes**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **yes**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **N/A**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services