You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Vincent Massol (JIRA)" <ji...@codehaus.org> on 2005/07/26 11:31:57 UTC
[jira] Created: (MNG-645) Allow for external reports
Allow for external reports
--------------------------
Key: MNG-645
URL: http://jira.codehaus.org/browse/MNG-645
Project: Maven 2
Type: Task
Components: maven-reports
Versions: 2.0-alpha-3
Reporter: Vincent Massol
Priority: Minor
Currently the AbstractMavenReport implementation has:
public void execute()
throws MojoExecutionException
{
try
{
String outputDirectory = getOutputDirectory();
XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
outputDirectory, getSiteDescriptor(), "maven" );
[...]
This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-645) Allow for external reports
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43442 ]
Brett Porter commented on MNG-645:
----------------------------------
I'm not sure it should extend a different base class. I'd prefer to just ensure the empty file doesn't get generated unless it needs to.
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Priority: Minor
> Fix For: 2.0-beta-1
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-645) Allow for external reports
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43424 ]
Emmanuel Venisse commented on MNG-645:
--------------------------------------
Look at javadoc report, it's an external report.
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Priority: Minor
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-645) Allow for external reports
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=all ]
Emmanuel Venisse closed MNG-645:
--------------------------------
Assign To: Emmanuel Venisse
Resolution: Fixed
I added isExternalReport method
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Assignee: Emmanuel Venisse
> Priority: Minor
> Fix For: 2.0-beta-1
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-645) Allow for external reports
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43445 ]
Vincent Massol commented on MNG-645:
------------------------------------
Yes, the other option is to have an abstract AbstractMavenReport.isExternalReport() method that report mojo must implement but I thought it would be better for the Mojo to choose the base class to extend instead. Sounds a bit cleaner to me but YMMV.
BTW, it isn't just about generation of an empty file but also about site resources copying.
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Priority: Minor
> Fix For: 2.0-beta-1
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-645) Allow for external reports
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=all ]
Brett Porter updated MNG-645:
-----------------------------
Fix Version: 2.0-beta-1
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Priority: Minor
> Fix For: 2.0-beta-1
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-645) Allow for external reports
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43431 ]
Vincent Massol commented on MNG-645:
------------------------------------
Thanks Emmanuel but looking at the javadoc report shows that it extends AbstractMavenReport but overrides one of its main method (generate()) thus negating what it does. In addition site resources are still generated and you need to also override the execute() method to prevent that.
I still believe the AbstractMavenReport currently doesn't support external reports. The best may be to have 2 abstract MavenReport implementations:
- AbstractExternalMavenReport
- AbstractMavenReport
I don't think it's right to extend something to negate its effect by overriding its key methods. Sounds hackish to me ;-)
> Allow for external reports
> --------------------------
>
> Key: MNG-645
> URL: http://jira.codehaus.org/browse/MNG-645
> Project: Maven 2
> Type: Task
> Components: maven-reports
> Versions: 2.0-alpha-3
> Reporter: Vincent Massol
> Priority: Minor
>
>
> Currently the AbstractMavenReport implementation has:
> public void execute()
> throws MojoExecutionException
> {
> try
> {
> String outputDirectory = getOutputDirectory();
> XhtmlSink sink = getSiteRenderer().createSink( new File( outputDirectory ), getOutputName() + ".html",
> outputDirectory, getSiteDescriptor(), "maven" );
> [...]
> This means that an HTML file with the report name will always be created. However, for the Clover plugin the HTML files are generated by the Clover API itself and we don't control them. Thus we don't need this clover.html file.
> I believe the AbstractMavenReport class should support report mojos that have externally generated HTML files too.
> For now, I've implemented MavenReport instead of extending AbstractMavenReport.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org