You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2023/05/05 02:32:00 UTC
[GitHub] [incubator-kvrocks] ZENOTME opened a new pull request, #1419: Support specify release candidate number
ZENOTME opened a new pull request, #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419
This PR closes #1407
it's to support specify like
`./x.py package source -v 2.3.2 -rc 1` and then create a tag '2.3.2-rc1'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1419: Support specify release candidate number
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#issuecomment-1535858502
Thanks @ZENOTME , merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ZENOTME commented on pull request #1419: Support specify release candidate number
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#issuecomment-1535633148
@mapleFU Thanks for reminding! Have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on pull request #1419: Support specify release candidate number
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#issuecomment-1535645698
Rest LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on a diff in pull request #1419: Support specify release candidate number
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185665485
##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
return version
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number: Optional[int]) -> None:
# 0. Write input version to VERSION file
version = write_version(release_version)
# 1. Git commit and tag
git = find_command('git', msg='git is required for source packaging')
run(git, 'commit', '-a', '-m', f'[source-release] prepare release apache-kvrocks-{version}')
- run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag v{version}')
-
-
+ if release_candidate_number == None:
+ run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag v{version}')
+ else:
+ run(git, 'tag', '-a', f'v{version}-rc{release_candidate_number}', '-m', f'[source-release] copy for tag v{version}')
Review Comment:
```
f'[source-release] copy for tag v{version}-rc{release_candidate_number}'
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on a diff in pull request #1419: Support specify release candidate number
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185663225
##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
return version
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number: int) -> None:
Review Comment:
Should it be an optional ( https://docs.python.org/3/library/typing.html#typing.Optional ) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1419: Support specify release candidate number
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1419: Support specify release candidate number
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185738327
##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
return version
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number: Optional[int]) -> None:
# 0. Write input version to VERSION file
version = write_version(release_version)
# 1. Git commit and tag
git = find_command('git', msg='git is required for source packaging')
run(git, 'commit', '-a', '-m', f'[source-release] prepare release apache-kvrocks-{version}')
- run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag v{version}')
-
-
+ if release_candidate_number == None:
Review Comment:
```suggestion
if release_candidate_number is None:
```
Pythonic and IIRC `==` here can be problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1419: Support specify release candidate number
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#issuecomment-1535775617
The release manual should be updated later also - https://github.com/apache/incubator-kvrocks-website/blob/f2ecdd3743fbbeddbbe293ced5fd49d6d74a0626/community/create-a-release.md?plain=1#L173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org