[GitHub] [madlib] kaknikhil commented on a change in pull request #445: updated DL preprocessor docs for bytea

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #445: updated DL preprocessor docs for bytea
URL: https://github.com/apache/madlib/pull/445#discussion_r330177158
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.sql_in
 ##########
 @@ -209,25 +214,39 @@ validation_preprocessor_dl(source_table,
     validation_preprocessor_dl() contain the following columns:
     <table class="output">
       <tr>
-        <th>buffer_id</th>
-        <td>INTEGER. Unique id for each row in the packed table.
+        <th>independent_var</th>
+        <td>BYTEA. Packed array of independent variables in PostgreSQL bytea format.
 
 Review comment:
   We can also add that the independent var is first normalized and then packed and converted to bytea. I understand that we already mentioned this in the function definition. But I believe that it will be valuable to mention it again just like we do for dependent_var

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services