You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Pil0tXia (via GitHub)" <gi...@apache.org> on 2024/04/05 18:41:53 UTC
[PR] [ISSUE #4812] Set up Admin Endpoints v2 (eventmesh)
Pil0tXia opened a new pull request, #4813:
URL: https://github.com/apache/eventmesh/pull/4813
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4812
### Motivation
Organize and optimize the code merged in https://github.com/apache/eventmesh/pull/4768, and implement v2 endpoints used for the new EventMesh Dashboard.
### Modifications
- Added PUT method to `org.apache.eventmesh.runtime.admin.handler.AbstractHttpHandler#handle`
- Eliminated the step of `getBytes` in `org.apache.eventmesh.runtime.admin.handler.AbstractHttpHandler#write`
- No need to construct `HttpResponse` with cross-origin headers in endpoint implementation code
- Cleaned up various overloaded methods that were messy and non-hierarchical
- For old endpoints, the path remains unchanged temporarily (endpoint path needs modification by Next.js Dashboard), suffix class names with V1, moved to v1 package; for new endpoints, use path /v2, do not suffix class names with V2, placed in v2 package.
- Corrected incorrect naming of annotations such as `@ConfigField`
- Implemented `/v2/configuration` endpoint, returning all Runtime configurations.
For detailed changes, refer to the naming of each commit.
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4812] Set up Admin Endpoints v2 (eventmesh)
Posted by "karsonto (via GitHub)" <gi...@apache.org>.
karsonto commented on PR #4813:
URL: https://github.com/apache/eventmesh/pull/4813#issuecomment-2041728837
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4812] Set up Admin Endpoints v2 (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4813:
URL: https://github.com/apache/eventmesh/pull/4813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4812] Set up Admin Endpoints v2 (eventmesh)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4813:
URL: https://github.com/apache/eventmesh/pull/4813#issuecomment-2040496456
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4813?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `38.96458%` with `224 lines` in your changes are missing coverage. Please review.
> Project coverage is 16.20%. Comparing base [(`98b1ed1`)](https://app.codecov.io/gh/apache/eventmesh/commit/98b1ed14041e5f46da9e24cd1e0e0725d3990358?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c14c936`)](https://app.codecov.io/gh/apache/eventmesh/pull/4813?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 4 commits behind head on master.
> :exclamation: Current head c14c936 differs from pull request most recent head 1930bbe. Consider uploading reports for the commit 1930bbe to get more accurate results
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4813?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...runtime/admin/handler/v2/ConfigurationHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2Fv2%2FConfigurationHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvdjIvQ29uZmlndXJhdGlvbkhhbmRsZXIuamF2YQ==) | 0.00% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...esh/runtime/admin/handler/AbstractHttpHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FAbstractHttpHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQWJzdHJhY3RIdHRwSGFuZGxlci5qYXZh) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/eventmesh/runtime/util/HttpRequestUtil.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Futil%2FHttpRequestUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvSHR0cFJlcXVlc3RVdGlsLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/eventmesh/runtime/util/HttpResponseUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Futil%2FHttpResponseUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvSHR0cFJlc3BvbnNlVXRpbHMuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/eventmesh/runtime/admin/response/Result.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fresponse%2FResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL1Jlc3VsdC5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...esh/runtime/admin/handler/AdminHandlerManager.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FAdminHandlerManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQWRtaW5IYW5kbGVyTWFuYWdlci5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mmon/config/convert/converter/ObjectConverter.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fconfig%2Fconvert%2Fconverter%2FObjectConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvY29udmVydC9jb252ZXJ0ZXIvT2JqZWN0Q29udmVydGVyLmphdmE=) | 53.84% | [1 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...me/admin/response/v2/GetConfigurationResponse.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fresponse%2Fv2%2FGetConfigurationResponse.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL3YyL0dldENvbmZpZ3VyYXRpb25SZXNwb25zZS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...entmesh/runtime/admin/handler/v1/EventHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2Fv1%2FEventHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvdjEvRXZlbnRIYW5kbGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/handler/v1/RedirectClientBySubSystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2Fv1%2FRedirectClientBySubSystemHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvdjEvUmVkaXJlY3RDbGllbnRCeVN1YlN5c3RlbUhhbmRsZXIuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [46 more](https://app.codecov.io/gh/apache/eventmesh/pull/4813?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4813 +/- ##
============================================
- Coverage 16.20% 16.20% -0.01%
Complexity 1710 1710
============================================
Files 857 858 +1
Lines 30883 30885 +2
Branches 2685 2693 +8
============================================
Hits 5005 5005
- Misses 25410 25412 +2
Partials 468 468
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4813?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org