You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sunitha Beeram via Review Board <no...@reviews.apache.org> on 2017/06/07 16:29:19 UTC
Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore
when new Conf object is used
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/
-----------------------------------------------------------
Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
Bugs: HIVE-16844
https://issues.apache.org/jira/browse/HIVE-16844
Repository: hive-git
Description
-------
HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8
Diff: https://reviews.apache.org/r/59885/diff/1/
Testing
-------
Can't provide unit tests to test the functionality, but problem is reproducible and one way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked connections. With the fix the same does not happen.
Thanks,
Sunitha Beeram
Re: Review Request 59885: HIVE-16844: Fix Connection leak in
ObjectStore when new Conf object is used
Posted by Sunitha Beeram via Review Board <no...@reviews.apache.org>.
> On June 7, 2017, 8:45 p.m., Anthony Hsu wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
> > Line 302 (original), 304 (patched)
> > <https://reviews.apache.org/r/59885/diff/1/?file=1743915#file1743915line304>
> >
> > Do we need to close the PersistenceManager as well?
Good point, but the call to shutdown() on line 301 closes pm.
- Sunitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/#review177222
-----------------------------------------------------------
On June 7, 2017, 4:29 p.m., Sunitha Beeram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59885/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 4:29 p.m.)
>
>
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
>
>
> Bugs: HIVE-16844
> https://issues.apache.org/jira/browse/HIVE-16844
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8
>
>
> Diff: https://reviews.apache.org/r/59885/diff/1/
>
>
> Testing
> -------
>
> Can't provide unit tests to test the functionality, but problem is reproducible and one way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked connections. With the fix the same does not happen.
>
>
> Thanks,
>
> Sunitha Beeram
>
>
Re: Review Request 59885: HIVE-16844: Fix Connection leak in
ObjectStore when new Conf object is used
Posted by Anthony Hsu via Review Board <no...@reviews.apache.org>.
> On 六月 7, 2017, 8:45 p.m., Anthony Hsu wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
> > Line 302 (original), 304 (patched)
> > <https://reviews.apache.org/r/59885/diff/1/?file=1743915#file1743915line304>
> >
> > Do we need to close the PersistenceManager as well?
>
> Sunitha Beeram wrote:
> Good point, but the call to shutdown() on line 301 closes pm.
Ah, yes, thanks for pointing that out.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/#review177222
-----------------------------------------------------------
On 六月 7, 2017, 4:29 p.m., Sunitha Beeram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59885/
> -----------------------------------------------------------
>
> (Updated 六月 7, 2017, 4:29 p.m.)
>
>
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
>
>
> Bugs: HIVE-16844
> https://issues.apache.org/jira/browse/HIVE-16844
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8
>
>
> Diff: https://reviews.apache.org/r/59885/diff/1/
>
>
> Testing
> -------
>
> Can't provide unit tests to test the functionality, but problem is reproducible and one way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked connections. With the fix the same does not happen.
>
>
> Thanks,
>
> Sunitha Beeram
>
>
Re: Review Request 59885: HIVE-16844: Fix Connection leak in
ObjectStore when new Conf object is used
Posted by Anthony Hsu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/#review177222
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Line 302 (original), 304 (patched)
<https://reviews.apache.org/r/59885/#comment250766>
Do we need to close the PersistenceManager as well?
- Anthony Hsu
On 六月 7, 2017, 4:29 p.m., Sunitha Beeram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59885/
> -----------------------------------------------------------
>
> (Updated 六月 7, 2017, 4:29 p.m.)
>
>
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
>
>
> Bugs: HIVE-16844
> https://issues.apache.org/jira/browse/HIVE-16844
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8
>
>
> Diff: https://reviews.apache.org/r/59885/diff/1/
>
>
> Testing
> -------
>
> Can't provide unit tests to test the functionality, but problem is reproducible and one way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked connections. With the fix the same does not happen.
>
>
> Thanks,
>
> Sunitha Beeram
>
>
Re: Review Request 59885: HIVE-16844: Fix Connection leak in
ObjectStore when new Conf object is used
Posted by Anthony Hsu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/#review177432
-----------------------------------------------------------
Ship it!
Looks good to me.
- Anthony Hsu
On 六月 7, 2017, 4:29 p.m., Sunitha Beeram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59885/
> -----------------------------------------------------------
>
> (Updated 六月 7, 2017, 4:29 p.m.)
>
>
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
>
>
> Bugs: HIVE-16844
> https://issues.apache.org/jira/browse/HIVE-16844
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8
>
>
> Diff: https://reviews.apache.org/r/59885/diff/1/
>
>
> Testing
> -------
>
> Can't provide unit tests to test the functionality, but problem is reproducible and one way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked connections. With the fix the same does not happen.
>
>
> Thanks,
>
> Sunitha Beeram
>
>