You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "VladaZakharova (via GitHub)" <gi...@apache.org> on 2023/08/14 07:10:16 UTC

[GitHub] [airflow] VladaZakharova commented on a diff in pull request #33315: Merge system tests for CloudSQLExportInstanceOperator into one test

VladaZakharova commented on code in PR #33315:
URL: https://github.com/apache/airflow/pull/33315#discussion_r1293054381


##########
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql.py:
##########
@@ -51,12 +51,14 @@
 PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT")
 DAG_ID = "cloudsql"
 
-INSTANCE_NAME = f"{DAG_ID}-{ENV_ID}-instance"
-DB_NAME = f"{DAG_ID}-{ENV_ID}-db"
+INSTANCE_NAME = f"{DAG_ID}-{ENV_ID}-instance".replace("_", "-")

Review Comment:
   Thank you for taking a look on this PR!
   You are right, the name of the instance is valid only if consists of dashes and letters only, in this case. 
   As this PR combines 2 system tests into one, the deferrable and sync mode are combined in one file, so created instance will be used in both cases (def and sync)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org