You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/06 21:55:00 UTC

[GitHub] [superset] michael-s-molina opened a new issue #13978: Explore unnecessary re-render

michael-s-molina opened a new issue #13978:
URL: https://github.com/apache/superset/issues/13978


   ## Description
   
   Avoid unnecessary re-render of the data table in Explore. As we can see in the video below, the data table is re-rendered even if the control being applied is not related to the table. We can improve the user experience by only re-rendering the data table if the modified control affects the table data.
   
   ## Screenshot
   
   https://user-images.githubusercontent.com/70410625/113782575-d1c7d900-9708-11eb-8135-b2c982073bd8.mov#13974 
   
   @junlincc @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Nicke7117 edited a comment on issue #13978: [Explore] data table unnecessary re-render

Posted by GitBox <gi...@apache.org>.
Nicke7117 edited a comment on issue #13978:
URL: https://github.com/apache/superset/issues/13978#issuecomment-815286995


   Is this something I could work on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Nicke7117 commented on issue #13978: [Explore] data table unnecessary re-render

Posted by GitBox <gi...@apache.org>.
Nicke7117 commented on issue #13978:
URL: https://github.com/apache/superset/issues/13978#issuecomment-815286995


   Could I try to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #13978: Explore unnecessary re-render

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13978:
URL: https://github.com/apache/superset/issues/13978#issuecomment-814635808


   Make sense, thanks for suggesting! 
   
   cc @kgabryje (not urgent, let's wait for next quality bash :) ) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #13978: [Explore] data table unnecessary re-render

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #13978:
URL: https://github.com/apache/superset/issues/13978#issuecomment-836527299


   @junlincc After careful investigation, we'll need some API changes to fix the re-render problem. In talks with @rusackas we decided to postpone the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Nicke7117 removed a comment on issue #13978: [Explore] data table unnecessary re-render

Posted by GitBox <gi...@apache.org>.
Nicke7117 removed a comment on issue #13978:
URL: https://github.com/apache/superset/issues/13978#issuecomment-815286995


   Is this something I could work on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org