You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/06/12 16:43:59 UTC

Review Request 35391: Provide reasonable error message when user tries to scale UI provisioned cluster via blueprint api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35391/
-----------------------------------------------------------

Review request for Ambari and Robert Nettleton.


Bugs: AMBARI-11886
    https://issues.apache.org/jira/browse/AMBARI-11886


Repository: ambari


Description
-------

In 2.1, scaling a UI provisioned cluster via the blueprint add hosts api isn't supported. Support for this use case has been deferred to 2.1.1.
Currently, if a user attempts to do this, a 500 response is returned.
This Jira is to fix the error to return a 400 response with a good error message.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java a75cccb 

Diff: https://reviews.apache.org/r/35391/diff/


Testing
-------

Functional Tests:
Both positive and negative functional tests.

Unit Tests:
Currently running entire unit test suite.  Will update with results prior to merging.


Thanks,

John Speidel


Re: Review Request 35391: Provide reasonable error message when user tries to scale UI provisioned cluster via blueprint api

Posted by John Speidel <js...@hortonworks.com>.

> On June 12, 2015, 3 p.m., Robert Nettleton wrote:
> > Ship It!

Results :

Tests run: 3083, Failures: 0, Errors: 0, Skipped: 28
...
Total run:754
Total errors:0
Total failures:0


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35391/#review87721
-----------------------------------------------------------


On June 12, 2015, 2:43 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35391/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 2:43 p.m.)
> 
> 
> Review request for Ambari and Robert Nettleton.
> 
> 
> Bugs: AMBARI-11886
>     https://issues.apache.org/jira/browse/AMBARI-11886
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In 2.1, scaling a UI provisioned cluster via the blueprint add hosts api isn't supported. Support for this use case has been deferred to 2.1.1.
> Currently, if a user attempts to do this, a 500 response is returned.
> This Jira is to fix the error to return a 400 response with a good error message.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java a75cccb 
> 
> Diff: https://reviews.apache.org/r/35391/diff/
> 
> 
> Testing
> -------
> 
> Functional Tests:
> Both positive and negative functional tests.
> 
> Unit Tests:
> Currently running entire unit test suite.  Will update with results prior to merging.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Re: Review Request 35391: Provide reasonable error message when user tries to scale UI provisioned cluster via blueprint api

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35391/#review87721
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On June 12, 2015, 2:43 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35391/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 2:43 p.m.)
> 
> 
> Review request for Ambari and Robert Nettleton.
> 
> 
> Bugs: AMBARI-11886
>     https://issues.apache.org/jira/browse/AMBARI-11886
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In 2.1, scaling a UI provisioned cluster via the blueprint add hosts api isn't supported. Support for this use case has been deferred to 2.1.1.
> Currently, if a user attempts to do this, a 500 response is returned.
> This Jira is to fix the error to return a 400 response with a good error message.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java a75cccb 
> 
> Diff: https://reviews.apache.org/r/35391/diff/
> 
> 
> Testing
> -------
> 
> Functional Tests:
> Both positive and negative functional tests.
> 
> Unit Tests:
> Currently running entire unit test suite.  Will update with results prior to merging.
> 
> 
> Thanks,
> 
> John Speidel
> 
>