You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2026/01/16 14:43:22 UTC

[PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

HappenLee opened a new pull request, #59980:
URL: https://github.com/apache/doris/pull/59980

   ### What problem does this PR solve?
   
   prevent coredump if row store not match in schema change, change the dcheck to return error code
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760331595

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760650102

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 176801 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 34aacb441be27d6b5b4e5edd4955b2774081aa83, data reload: false
   
   query5	4746	656	504	504
   query6	343	242	231	231
   query7	4222	492	277	277
   query8	354	272	268	268
   query9	8762	3176	3138	3138
   query10	506	392	350	350
   query11	15351	15179	15023	15023
   query12	181	121	113	113
   query13	1262	520	411	411
   query14	6325	3080	2880	2880
   query14_1	2726	2722	2745	2722
   query15	214	202	176	176
   query16	978	502	482	482
   query17	1098	676	586	586
   query18	2570	449	355	355
   query19	232	226	194	194
   query20	126	121	126	121
   query21	224	141	119	119
   query22	3987	4291	3929	3929
   query23	16071	15724	15402	15402
   query23_1	15515	15399	15507	15399
   query24	7130	1594	1203	1203
   query24_1	1212	1206	1217	1206
   query25	515	430	393	393
   query26	1248	275	159	159
   query27	2760	453	300	300
   query28	4497	2345	2317	2317
   query29	750	530	450	450
   query30	314	256	211	211
   query31	809	640	582	582
   query32	92	81	72	72
   query33	527	354	325	325
   query34	924	915	556	556
   query35	736	748	670	670
   query36	937	984	857	857
   query37	139	106	91	91
   query38	2732	2716	2611	2611
   query39	785	748	738	738
   query39_1	721	738	731	731
   query40	226	134	128	128
   query41	73	70	66	66
   query42	110	114	105	105
   query43	473	494	444	444
   query44	1440	812	823	812
   query45	192	184	184	184
   query46	876	968	612	612
   query47	1428	1464	1357	1357
   query48	334	370	258	258
   query49	616	442	362	362
   query50	659	306	219	219
   query51	3844	3842	3805	3805
   query52	113	111	100	100
   query53	308	334	273	273
   query54	298	277	266	266
   query55	89	84	83	83
   query56	320	315	345	315
   query57	1064	1074	967	967
   query58	276	270	279	270
   query59	2148	2269	2340	2269
   query60	348	343	322	322
   query61	158	153	148	148
   query62	426	376	323	323
   query63	295	270	267	267
   query64	4848	1291	1026	1026
   query65	3939	3747	3773	3747
   query66	1444	455	355	355
   query67	15690	15759	15526	15526
   query68	2499	1205	840	840
   query69	459	384	359	359
   query70	1066	973	946	946
   query71	343	323	315	315
   query72	5494	3331	3365	3331
   query73	663	755	336	336
   query74	8811	8841	8587	8587
   query75	2771	2831	2484	2484
   query76	2287	1089	686	686
   query77	375	411	316	316
   query78	9831	9963	9085	9085
   query79	1735	933	653	653
   query80	1320	596	495	495
   query81	553	268	249	249
   query82	950	150	115	115
   query83	347	276	245	245
   query84	258	131	119	119
   query85	915	509	447	447
   query86	418	341	305	305
   query87	2917	2866	2763	2763
   query88	3869	2841	2807	2807
   query89	414	358	335	335
   query90	1961	188	166	166
   query91	176	172	152	152
   query92	81	78	74	74
   query93	1161	956	591	591
   query94	650	341	312	312
   query95	619	414	344	344
   query96	712	520	249	249
   query97	2359	2394	2349	2349
   query98	219	207	206	206
   query99	632	624	552	552
   Total cold run time: 250658 ms
   Total hot run time: 176801 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3762941628

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #59980:
URL: https://github.com/apache/doris/pull/59980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3762941604

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3763032898

   skip check_coverage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760770660

   # BE UT Coverage Report
   Increment line coverage `0.00% (0/8)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/34aacb441be27d6b5b4e5edd4955b2774081aa83_34aacb441be27d6b5b4e5edd4955b2774081aa83/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/34aacb441be27d6b5b4e5edd4955b2774081aa83_34aacb441be27d6b5b4e5edd4955b2774081aa83/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.39% (19029/36319) |
   | Line Coverage     | 35.71% (176332/493725) |
   | Region Coverage   | 32.26% (136551/423318) |
   | Branch Coverage   | 33.14% (59015/178059) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760593835

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 32839 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 34aacb441be27d6b5b4e5edd4955b2774081aa83, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17614	4290	4102	4102
   q2	2066	350	242	242
   q3	10123	1259	726	726
   q4	10205	776	312	312
   q5	7518	2117	1868	1868
   q6	201	171	143	143
   q7	962	801	658	658
   q8	9278	1394	1217	1217
   q9	4969	4621	4559	4559
   q10	6797	1819	1410	1410
   q11	532	320	304	304
   q12	702	755	616	616
   q13	17810	3941	3182	3182
   q14	304	304	284	284
   q15	590	523	500	500
   q16	714	698	643	643
   q17	722	843	514	514
   q18	6999	6685	7135	6685
   q19	1590	1112	783	783
   q20	447	421	295	295
   q21	3331	2693	2690	2690
   q22	1178	1116	1106	1106
   Total cold run time: 104652 ms
   Total hot run time: 32839 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4387	4255	4312	4255
   q2	356	420	331	331
   q3	2316	2863	2366	2366
   q4	1474	1906	1617	1617
   q5	4509	4320	4429	4320
   q6	221	182	135	135
   q7	2122	1923	1814	1814
   q8	2583	2380	2394	2380
   q9	7136	7061	7261	7061
   q10	2472	2561	2145	2145
   q11	541	458	442	442
   q12	689	701	575	575
   q13	3407	3858	3281	3281
   q14	274	293	264	264
   q15	520	486	489	486
   q16	639	680	632	632
   q17	1124	1289	1282	1282
   q18	7349	7366	7203	7203
   q19	931	889	879	879
   q20	1891	1949	1808	1808
   q21	4601	4271	4189	4189
   q22	1052	1041	992	992
   Total cold run time: 50594 ms
   Total hot run time: 48457 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760335067

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Exec](topn) prevent coredump if row store not match in schema change [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59980:
URL: https://github.com/apache/doris/pull/59980#issuecomment-3760671220

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.29 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 34aacb441be27d6b5b4e5edd4955b2774081aa83, data reload: false
   
   query1	0.07	0.05	0.05
   query2	0.10	0.05	0.05
   query3	0.26	0.09	0.09
   query4	1.60	0.12	0.12
   query5	0.27	0.26	0.26
   query6	1.15	0.68	0.66
   query7	0.03	0.02	0.03
   query8	0.06	0.04	0.04
   query9	0.58	0.50	0.52
   query10	0.57	0.57	0.56
   query11	0.16	0.10	0.10
   query12	0.14	0.11	0.12
   query13	0.61	0.60	0.58
   query14	0.96	0.95	0.96
   query15	0.80	0.78	0.78
   query16	0.40	0.39	0.40
   query17	1.09	1.08	1.05
   query18	0.24	0.22	0.21
   query19	1.93	1.91	1.92
   query20	0.02	0.01	0.02
   query21	15.43	0.27	0.15
   query22	5.42	0.06	0.05
   query23	16.04	0.30	0.11
   query24	1.73	0.36	0.36
   query25	0.12	0.07	0.07
   query26	0.15	0.14	0.15
   query27	0.09	0.06	0.07
   query28	4.33	1.10	0.89
   query29	12.55	4.02	3.22
   query30	0.28	0.15	0.12
   query31	2.82	0.65	0.39
   query32	3.25	0.58	0.46
   query33	3.05	3.05	3.12
   query34	15.95	5.10	4.47
   query35	4.44	4.44	4.46
   query36	0.66	0.51	0.50
   query37	0.11	0.07	0.06
   query38	0.08	0.04	0.04
   query39	0.05	0.04	0.03
   query40	0.17	0.15	0.14
   query41	0.09	0.04	0.03
   query42	0.04	0.03	0.03
   query43	0.04	0.04	0.04
   Total cold run time: 97.93 s
   Total hot run time: 27.29 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org