You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/13 02:58:04 UTC

Review Request 21354: Fixed duration calculation in the job page.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21354/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Bugs: AURORA-411
    https://issues.apache.org/jira/browse/AURORA-411


Repository: aurora


Description
-------

Fixed duration calculation in the job page.


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 768c4fe0db2813c50400370390a34cd428f88df5 

Diff: https://reviews.apache.org/r/21354/diff/


Testing
-------

Tested locally on laptop. Attached screenshot.


File Attachments
----------------

Now showing correct duration
  https://reviews.apache.org/media/uploaded/files/2014/05/13/f3afd556-c062-4829-ba9c-cd30d04b74fc__Screen_Shot_2014-05-12_at_5.49.51_PM.png


Thanks,

Suman Karumuri


Re: Review Request 21354: Fixed duration calculation in the job page.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21354/#review42872
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Chu-Carroll


On May 12, 2014, 8:58 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21354/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 8:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-411
>     https://issues.apache.org/jira/browse/AURORA-411
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed duration calculation in the job page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 768c4fe0db2813c50400370390a34cd428f88df5 
> 
> Diff: https://reviews.apache.org/r/21354/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on laptop. Attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Now showing correct duration
>   https://reviews.apache.org/media/uploaded/files/2014/05/13/f3afd556-c062-4829-ba9c-cd30d04b74fc__Screen_Shot_2014-05-12_at_5.49.51_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 21354: Fixed duration calculation in the job page.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21354/#review42896
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On May 13, 2014, 12:58 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21354/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 12:58 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-411
>     https://issues.apache.org/jira/browse/AURORA-411
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed duration calculation in the job page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 768c4fe0db2813c50400370390a34cd428f88df5 
> 
> Diff: https://reviews.apache.org/r/21354/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on laptop. Attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Now showing correct duration
>   https://reviews.apache.org/media/uploaded/files/2014/05/13/f3afd556-c062-4829-ba9c-cd30d04b74fc__Screen_Shot_2014-05-12_at_5.49.51_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>