You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/03/21 23:47:13 UTC
Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2510
https://issues.apache.org/jira/browse/ATLAS-2510
Repository: atlas
Description
-------
Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
Disable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Enable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
Diff: https://reviews.apache.org/r/66203/diff/1/
Testing
-------
Validated disable and enable of propagated classification through REST client - POSTMAN.
Thanks,
Sarath Subramanian
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review199729
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 130 (patched)
<https://reviews.apache.org/r/66203/#comment280159>
06G --> 070
06H --> 071
- Apoorv Naik
On March 21, 2018, 11:47 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 11:47 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2510
> https://issues.apache.org/jira/browse/ATLAS-2510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
>
> The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
>
>
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
>
>
> Diff: https://reviews.apache.org/r/66203/diff/1/
>
>
> Testing
> -------
>
> Validated disable and enable of propagated classification through REST client - POSTMAN.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Sarath Subramanian <sa...@apache.org>.
> On March 21, 2018, 8:04 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
> > Line 966 (original), 969 (patched)
> > <https://reviews.apache.org/r/66203/diff/1/?file=1985034#file1985034line971>
> >
> > Looking for edge by classificationName? How does this handle multiple classifications of the same name being associated with the entity - directly and via propagation?
>
> Sarath Subramanian wrote:
> 1. getClassificationEdge(entityVertex, classificationName) method returns directly associated classification edges since no duplicate classificationName is present for directly associated classification.
> 2. getPropagatedClassificationEdge(entityVertex, classificationName, associatedEntityGuid) method returns all propagated edges matching the classificationName and associatedEntityGuid.
Good catch! modified getClassificationEdge() method to pass classificationVertex to chose the right edge.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review199737
-----------------------------------------------------------
On March 22, 2018, 9:31 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 9:31 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2510
> https://issues.apache.org/jira/browse/ATLAS-2510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
>
> The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
>
>
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
>
>
> Diff: https://reviews.apache.org/r/66203/diff/2/
>
>
> Testing
> -------
>
> Validated disable and enable of propagated classification through REST client - POSTMAN.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review199737
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 1002 (patched)
<https://reviews.apache.org/r/66203/#comment280185>
I think 'ACTIVE' might be a good choice when edge doesn't have the 'state' property.
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
Lines 161 (patched)
<https://reviews.apache.org/r/66203/#comment280186>
togglePropagatedClassification() ==> setPropagatedClassificationStateForEntity(entityGuid, classificationName, sourceEntityGuid, propagationState)
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 966 (original), 969 (patched)
<https://reviews.apache.org/r/66203/#comment280188>
Looking for edge by classificationName? How does this handle multiple classifications of the same name being associated with the entity - directly and via propagation?
- Madhan Neethiraj
On March 21, 2018, 11:47 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 11:47 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2510
> https://issues.apache.org/jira/browse/ATLAS-2510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
>
> The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
>
>
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
>
>
> Diff: https://reviews.apache.org/r/66203/diff/1/
>
>
> Testing
> -------
>
> Validated disable and enable of propagated classification through REST client - POSTMAN.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review200006
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 85 (patched)
<https://reviews.apache.org/r/66203/#comment280591>
Consider renaming 'disabledPropagatedClassifications' to 'propagationDisabledClassifications'
- Madhan Neethiraj
On March 26, 2018, 11:14 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 11:14 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2510
> https://issues.apache.org/jira/browse/ATLAS-2510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
>
> The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
>
>
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da9
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bfb5a711
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 19ac6209
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c76f6405
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 8fe635ae
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 9b4c91d1
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
>
>
> Diff: https://reviews.apache.org/r/66203/diff/5/
>
>
> Testing
> -------
>
> Validated disable and enable of propagated classification through REST client - POSTMAN.
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review200036
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 419 (patched)
<https://reviews.apache.org/r/66203/#comment280628>
If I have understood correctly; I think the proposal here is that a propogated classification can be disabled - this is implmented using a soft delete. Please could you confirm that any downstream propagated classifications are also disabled?
- David Radley
On March 27, 2018, 5:26 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
>
> (Updated March 27, 2018, 5:26 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2510
> https://issues.apache.org/jira/browse/ATLAS-2510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
>
> The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
>
>
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da9
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bfb5a711
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 19ac6209
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c76f6405
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 8fe635ae
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 9b4c91d1
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
>
>
> Diff: https://reviews.apache.org/r/66203/diff/6/
>
>
> Testing
> -------
>
> Validated disable and enable of propagated classification through REST client - POSTMAN.
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/
-----------------------------------------------------------
(Updated March 26, 2018, 10:26 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2510
https://issues.apache.org/jira/browse/ATLAS-2510
Repository: atlas
Description
-------
Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
Disable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Enable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da9
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bfb5a711
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 19ac6209
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c76f6405
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 8fe635ae
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 9b4c91d1
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
Diff: https://reviews.apache.org/r/66203/diff/6/
Changes: https://reviews.apache.org/r/66203/diff/5-6/
Testing
-------
Validated disable and enable of propagated classification through REST client - POSTMAN.
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console
Thanks,
Sarath Subramanian
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/
-----------------------------------------------------------
(Updated March 26, 2018, 4:14 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
Added disablePropagatedClassifications in AtlasEntity to retrieve all disabled propagated classifications.
Bugs: ATLAS-2510
https://issues.apache.org/jira/browse/ATLAS-2510
Repository: atlas
Description
-------
Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
Disable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Enable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da9
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bfb5a711
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 19ac6209
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c76f6405
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 8fe635ae
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 9b4c91d1
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
Diff: https://reviews.apache.org/r/66203/diff/5/
Changes: https://reviews.apache.org/r/66203/diff/4-5/
Testing
-------
Validated disable and enable of propagated classification through REST client - POSTMAN.
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console
Thanks,
Sarath Subramanian
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/
-----------------------------------------------------------
(Updated March 22, 2018, 10:54 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
addressed review comments.
Bugs: ATLAS-2510
https://issues.apache.org/jira/browse/ATLAS-2510
Repository: atlas
Description
-------
Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
Disable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Enable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
Diff: https://reviews.apache.org/r/66203/diff/3/
Changes: https://reviews.apache.org/r/66203/diff/2-3/
Testing
-------
Validated disable and enable of propagated classification through REST client - POSTMAN.
Thanks,
Sarath Subramanian
Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable
propagated classification in entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/
-----------------------------------------------------------
(Updated March 22, 2018, 9:31 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2510
https://issues.apache.org/jira/browse/ATLAS-2510
Repository: atlas
Description
-------
Currently there is no way to remove propagated classification from an entity. This Jira provides capability to disable/enable a propagated classification from an entity using REST.
The propagated classification name and its associated entity guid is supplied to the REST to disable/enable right propagated classification.
Disable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Enable a propagated tag:
curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' -H 'Authorization: Basic YWRtaW46YWRtaW4='
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 79e8e3e8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java b5461d4b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1
Diff: https://reviews.apache.org/r/66203/diff/2/
Changes: https://reviews.apache.org/r/66203/diff/1-2/
Testing
-------
Validated disable and enable of propagated classification through REST client - POSTMAN.
Thanks,
Sarath Subramanian