You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/30 01:37:48 UTC

[PR] fix(common): isolate page result items [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2830:
URL: https://github.com/apache/rocketmq-dashboard/pull/2830

   ## Summary
   - copy page items when constructing a `PageResult`
   - expose an unmodifiable page list without changing null-element behavior
   - add regression coverage for source-list and caller mutation
   
   ## Why
   `PageResult` retained the caller's mutable list (including `subList` views), so later source mutations could change an already returned page and callers could mutate shared backing state.
   
   ## Testing
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -f server/pom.xml -Dtest=PageResultTest test`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(common): isolate page result items [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2830: fix(common): isolate page result items
URL: https://github.com/apache/rocketmq-dashboard/pull/2830


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(common): isolate page result items [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2830:
URL: https://github.com/apache/rocketmq-dashboard/pull/2830#issuecomment-5477629231

   Merged into the #2656 consolidation batch (same author, backend sanitization fixes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org