You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 08:42:05 UTC

[GitHub] [airflow] potiuk opened a new pull request #13055: Allows to install Airflow in Breeze from PIP with configurable extras

potiuk opened a new pull request #13055:
URL: https://github.com/apache/airflow/pull/13055


   The extras configured by --extras Breeze switch are now
   passed to pip install command in case airfow is installed via
   --install-airflow-version or --install-airflow-reference switch.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13055: Allows to install Airflow in Breeze from PIP with configurable extras

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13055:
URL: https://github.com/apache/airflow/pull/13055#issuecomment-744281464


   This one is very hjelpful when testing RCS with small subset of providers:
   
   For example you can do this:
   
   ```
   ./breeze start-airflow --backend postgres --load-example-dags --load-default-connections --install-airflow-version 2.0.0rc2 --extras "amazon" --python 3.8 --backend postgres
   ```
   
   And you have up-and-running airflow with only RC + base providers + amazon installed. Currently in CI we also install `snowflake` with turns out breaks SSL not only for kerberos + presto but also for boto3, so it is helpful to install different set of extras. With this change it also skips mounting local sources when you install airflow from PyPI so you do not have local source providers automatically added.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #13055: Allows to install Airflow in Breeze from PIP with configurable extras

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13055:
URL: https://github.com/apache/airflow/pull/13055#issuecomment-744281464


   This one is very helpful when testing RCS with small subset of providers:
   
   For example you can do this:
   
   ```
   ./breeze start-airflow --backend postgres --load-example-dags --load-default-connections \
      --install-airflow-version 2.0.0rc2 --extras "amazon" --python 3.8 --backend postgres
   ```
   
   And you have up-and-running airflow with only RC + base providers + amazon installed. Currently in CI we also install `snowflake` with turns out breaks SSL not only for kerberos + presto but also for boto3, so it is helpful to install different set of extras. With this change it also skips mounting local sources when you install airflow from PyPI so you do not have local source providers automatically added.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #13055: Allows to install Airflow in Breeze from PIP with configurable extras

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13055:
URL: https://github.com/apache/airflow/pull/13055#issuecomment-744461679


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #13055: Allows to install Airflow in Breeze from PIP with configurable extras

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13055:
URL: https://github.com/apache/airflow/pull/13055


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org