[GitHub] [incubator-mxnet] larroy commented on issue #16741: Error detecting C++11 and C++14

[GitBox <gi...@apache.org>]

larroy commented on issue #16741: Error detecting C++11 and C++14
URL: https://github.com/apache/incubator-mxnet/issues/16741#issuecomment-554516763
 
 
   those flags with dash are in the else branch of the MSVC conditional, how can they be added to your build flags? Can you add a print in the cmakefile to make sure you are in the MSVC branch?  I agree these flags should not be present, something is wrong if they are.
   
   Note that they are added in the else case:
   
   ```
   
   else(MSVC)
     include(CheckCXXCompilerFlag)
     if(USE_CXX14_IF_AVAILABLE)
       check_cxx_compiler_flag("-std=c++14" SUPPORT_CXX14)
     endif()
     check_cxx_compiler_flag("-std=c++11"   SUPPORT_CXX11)
     check_cxx_compiler_flag("-std=c++0x"   SUPPORT_CXX0X)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services