You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "adamdebreceni (via GitHub)" <gi...@apache.org> on 2023/10/25 07:52:58 UTC

Re: [PR] MINIFICPP-1951 - Prevent append overwriting resource [nifi-minifi-cpp]

adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1371306139


##########
libminifi/include/core/ContentRepository.h:
##########
@@ -62,15 +73,24 @@ class ContentRepository : public core::CoreComponent, public StreamManager<minif
     return getName();
   }
 
+  std::unique_ptr<StreamAppendLock> append(const ResourceClaim& claim, size_t offset) override;

Review Comment:
   I don't think we can override with a different return type even if they are convertible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org