You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2007/08/14 00:51:30 UTC
[jira] Created: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Unhandled exception in Block CRC upgrade on datanode.
-----------------------------------------------------
Key: HADOOP-1712
URL: https://issues.apache.org/jira/browse/HADOOP-1712
Project: Hadoop
Issue Type: Bug
Components: dfs
Affects Versions: 0.14.0
Reporter: Raghu Angadi
Assignee: Raghu Angadi
Priority: Blocker
Fix For: 0.14.0
One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
exception on the datanode :
{noformat}
2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
at java.lang.Thread.run(Thread.java:619)
{noformat}
Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519801 ]
Konstantin Shvachko commented on HADOOP-1712:
---------------------------------------------
# import Random can be removed.
# BlockCrcUpgradeObjectDatanode.doUpgrade() should not catch and re-throw RuntimeException, because the framework
already catches Exception and loops. I don't see the point of catching the same exception twice here.
# BlockCrcUpgradeObjectDatanode.doUpgrade() should be declared to throw an IOException as the abstract declaration does.
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-1712:
---------------------------------
Status: Patch Available (was: Open)
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch, HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-1712:
---------------------------------
Attachment: HADOOP-1712.patch
This patch fixes the above problem.
Changed 'doUpgrade()' not to throw IOException so that we don't miss such exceptions. Also doUpgrade catches RuntimException, logs it and then throws if it ever occurs.
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-1712:
---------------------------------
Attachment: HADOOP-1712.patch
Thanks for the review Konstantin.
Updated the patch with suggested changes.
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch, HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1712) Unhandled exception in Block CRC
upgrade on datanode.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-1712:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Raghu!
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch, HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode: java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.