You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/19 05:50:14 UTC

[GitHub] [skywalking] liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575969960
 
 
   > Any update?
   
   Actually, I think that `#moveTo` when doing `#in` is redundant, which can be covered by `#add` operation, and `#moveTo` in `#add` is an essential mechanism to make `public void add()` more safe at `window`'s initial stage, another PR will be created today :). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services