[jira] [Commented] (FLINK-10638) Invalid table scan resolution for temporal join queries

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658775#comment-16658775 ] 

ASF GitHub Bot commented on FLINK-10638:
----------------------------------------

twalthr opened a new pull request #6893: [FLINK-10638] [table] Fix table scan resolution for temporal join queries
URL: https://github.com/apache/flink/pull/6893
 
 
   ## What is the purpose of the change
   
   Changes the optimization order such that table scans are resolved to full plan nodes before performing temporal join conversion.
   
   ## Brief change log
   
   - Optimization order changed.
   
   
   ## Verifying this change
   
   Extended temporal join IT case.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Invalid table scan resolution for temporal join queries
> -------------------------------------------------------
>
>                 Key: FLINK-10638
>                 URL: https://issues.apache.org/jira/browse/FLINK-10638
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> Registered tables that contain a temporal join are not properly resolved when performing a table scan.
> A planning error occurs when registering a table with a temporal join and reading from it again.
> {code}
> LogicalProject(amount=[*($0, $4)])
>   LogicalFilter(condition=[=($3, $1)])
>     LogicalCorrelate(correlation=[$cor0], joinType=[inner], requiredColumns=[{2}])
>       LogicalTableScan(table=[[_DataStreamTable_0]])
>       LogicalTableFunctionScan(invocation=[Rates(CAST($cor0.rowtime):TIMESTAMP(3) NOT NULL)], rowType=[RecordType(VARCHAR(65536) currency, BIGINT rate, TIME ATTRIBUTE(ROWTIME) rowtime)], elementType=[class [Ljava.lang.Object;])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)