You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "wcarlson5 (via GitHub)" <gi...@apache.org> on 2023/03/21 16:36:44 UTC

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13382: KAFKA-14722: Make BooleanSerde public

wcarlson5 commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1143691894


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java:
##########
@@ -48,42 +45,4 @@ public NullableValueAndTimestampSerde(final Serde<V> valueSerde) {
         );
     }
 
-    static final class BooleanSerde {

Review Comment:
   Are there tests for this code that need to cleaned up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org