You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kiyoshi Mizumaru (Code Review)" <ge...@cloudera.org> on 2018/08/25 12:28:04 UTC

[kudu-CR] [kudu-backup] fix tests

Kiyoshi Mizumaru has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11328


Change subject: [kudu-backup] fix tests
......................................................................

[kudu-backup] fix tests

- Previously TestKuduBackup class wasn't executed in
  ./gradlew test, ./gradlew :kudu-backup:test, mvn test, ...

- TestKuduBackup#testRandomBackupAndRestore was failed in
  a column of Type.BINARY

Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 1 insertion(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/11328/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
Gerrit-Change-Number: 11328
Gerrit-PatchSet: 1
Gerrit-Owner: Kiyoshi Mizumaru <ki...@gmail.com>

[kudu-CR] [kudu-backup] fix tests

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11328 )

Change subject: [kudu-backup] fix tests
......................................................................

[kudu-backup] fix tests

- Previously TestKuduBackup class wasn't executed in
  ./gradlew test, ./gradlew :kudu-backup:test, mvn test, ...

- TestKuduBackup#testRandomBackupAndRestore was failed in
  a column of Type.BINARY

Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
Reviewed-on: http://gerrit.cloudera.org:8080/11328
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
Gerrit-Change-Number: 11328
Gerrit-PatchSet: 2
Gerrit-Owner: Kiyoshi Mizumaru <ki...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [kudu-backup] fix tests

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11328 )

Change subject: [kudu-backup] fix tests
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
Gerrit-Change-Number: 11328
Gerrit-PatchSet: 1
Gerrit-Owner: Kiyoshi Mizumaru <ki...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 19:39:32 +0000
Gerrit-HasComments: No