You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/10 01:03:47 UTC
[GitHub] [arrow] kou commented on a change in pull request #10710: ARROW-11460: [R] Use system libraries if present on Linux
kou commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r685617384
##########
File path: r/configure
##########
@@ -173,6 +186,11 @@ else
BUNDLED_LIBS=`echo "$BUNDLED_LIBS" | sed -e "s/\\.a lib/ -l/g" | sed -e "s/\\.a$//" | sed -e "s/^lib/-l/" | tr '\n' ' ' | sed -e "s/ $//"`
PKG_DIRS="-L`pwd`/$LIB_DIR"
+ # Use pkg-config to do static linking of libarrow's dependencies
+ if [[ "$ARROW_DEPENDENCY_SOURCE" = "AUTO" || "$ARROW_DEPENDENCY_SOURCE" = "SYSTEM" ]]; then
Review comment:
We should use `[` not `[[` because `/bin/sh` may not be bash`: https://github.com/ursacomputing/crossbow/runs/3280854203?check_suite_focus=true#step:7:4328
```text
./configure: 190: [[: not found
./configure: 190: SYSTEM: not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org