[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42173: [SPARK-44544][INFRA][FOLLOWUP] run `run_python_packaging_tests` even if `pyspark-errors` is skipped

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42173:
URL: https://github.com/apache/spark/pull/42173#discussion_r1275590975


##########
dev/run-tests.py:
##########
@@ -559,6 +559,10 @@ def main():
 
         changed_modules = test_modules
         if len(changed_modules) == 0:
+            # If SKIP_PACKAGING is explicitly set (no matter true or false),
+            # let run_python_packaging_tests to determine whether it should be run.
+            if not os.environ.get("SKIP_PYTHON") and os.environ.get("SKIP_PACKAGING") is not None:
+                run_python_packaging_tests()

Review Comment:
   Hm, to run pip packaging test, Spark has to be built first but here is before we build. I think it won't work correctly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org