You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "gracecluvohio (via GitHub)" <gi...@apache.org> on 2026/04/21 20:51:08 UTC
[PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
gracecluvohio opened a new pull request, #36:
URL: https://github.com/apache/incubator-texera-site/pull/36
## Summary
This PR adds documentation for what developers should do if their PR changes the SQL schema.
## What's Changed
- modified `/content/en/docs/contribution-guidelines/_index.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3121653796
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+ > **Modifying the SQL schema?**
+ > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
Review Comment:
Could you make this a bit more detailed? For example, it would help to clarify where sql/changelog.xml should be updated and what the expected SQL file format looks like. If possible, adding a screenshot/code snippet would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3150065735
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+ > **Modifying the SQL schema?**
+ > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
Review Comment:
There are some comments to specify how to update `sql/changelog.xml` in that file already. However, I can add some comments to make it more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3163220532
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+
> **Modifying the SQL schema?**
- > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
+ > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element.
+ > 2. The file format of your SQL update file should be:
+ > ```
+ > SET search_path TO texera_db;
+ > BEGIN;
+ > [your changes here]
+ > COMMIT;
+ > ```
+ > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line.
Review Comment:
Sounds good. I'll update the original PR + the documentation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3121617746
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+ - If your PR modifies the SQL schema, be sure to modify `sql/changelog.xml`.
+ - Also omit `\c texera_db` from the top of your SQL update file as Liquibase cannot parse this line.
Review Comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3150780882
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+
> **Modifying the SQL schema?**
- > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
+ > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element.
+ > 2. The file format of your SQL update file should be:
+ > ```
+ > SET search_path TO texera_db;
+ > BEGIN;
+ > [your changes here]
+ > COMMIT;
+ > ```
+ > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line.
Review Comment:
> does this mean developers should manually omit \c texera_db from new SQL update files?
It means that going forward, developers who add a new SQL update file should not include it.
> Since running the SQL update file through Liquibase is optional, would removing this line cause any issues when developers run the file manually without Liquibase?
It would, developers would need to make sure they connect to `texera_db` before they apply the change using the old method. Not sure if this is an issue, but if it is, I can think of some ways to address it.
1. Going forward, require all developers to use `docker compose up` under the `sql` directory to apply new schema changes.
2. Keep the old format with `\c texera_db`, but in the docker compose file, create a small script that strips lines starting with `\c` before applying the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3151677572
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+
> **Modifying the SQL schema?**
- > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
+ > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element.
+ > 2. The file format of your SQL update file should be:
+ > ```
+ > SET search_path TO texera_db;
+ > BEGIN;
+ > [your changes here]
+ > COMMIT;
+ > ```
+ > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line.
Review Comment:
I think this feature should be an add-on — it shouldn't change the existing developer experience, and the convention across update files should stay consistent. With that in mind, I'd suggest going with the option of keeping \c texera_db in the SQL files and stripping it in the docker compose entrypoint before handing off to Liquibase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3150412572
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+
> **Modifying the SQL schema?**
- > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
+ > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element.
+ > 2. The file format of your SQL update file should be:
+ > ```
+ > SET search_path TO texera_db;
+ > BEGIN;
+ > [your changes here]
+ > COMMIT;
+ > ```
+ > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line.
Review Comment:
does this mean developers should manually omit `\c texera_db` from new SQL update files?
Since running the SQL update file through Liquibase is optional, would removing this line cause any issues when developers run the file manually without Liquibase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on code in PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3120609655
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+ - If your PR modifies the SQL schema, be sure to modify `sql/changelog.xml`.
+ - Also omit `\c texera_db` from the top of your SQL update file as Liquibase cannot parse this line.
Review Comment:
```suggestion
> **Modifying the SQL schema?**
> Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line.
```
##########
content/en/docs/contribution-guidelines/_index.md:
##########
@@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo
### 3. Create and Submit a Pull Request
- Develop in a new branch of your fork.
+ - If your PR modifies the SQL schema, be sure to modify `sql/changelog.xml`.
+ - Also omit `\c texera_db` from the top of your SQL update file as Liquibase cannot parse this line.
- When ready, submit a PR to the main Texera repository.
- **Allow edits from maintainers** to let committers make small fixes if needed.
Review Comment:
This appears to be a warning, and I think it should be moved to this line, in block quotes (as suggested above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add documentation for changes in sql migration notification process [incubator-texera-site]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on PR #36:
URL: https://github.com/apache/incubator-texera-site/pull/36#issuecomment-4291691557
@mengw15 Please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org