You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 10:56:17 UTC
[GitHub] [airflow] ashb opened a new pull request #21489: Fix broken tests after URL restructure PR
ashb opened a new pull request #21489:
URL: https://github.com/apache/airflow/pull/21489
#20730 somehow broken tests, not sure how that PR was green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #21489: Fix broken tests after URL restructure PR
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #21489:
URL: https://github.com/apache/airflow/pull/21489#discussion_r803548113
##########
File path: airflow/utils/helpers.py
##########
@@ -258,8 +257,7 @@ def build_airflow_url_with_query(query: Dict[str, Any]) -> str:
import flask
view = conf.get('webserver', 'dag_default_view').lower()
- url = flask.url_for(f"Airflow.{view}")
- return f"{url}?{parse.urlencode(query)}"
+ return flask.url_for(f"Airflow.{view}", **query)
Review comment:
Turns out url_for handles url prams and everything else gets set as query params, so the fix was easy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21489: Fix broken tests after URL restructure PR
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21489:
URL: https://github.com/apache/airflow/pull/21489#issuecomment-1034786259
also cc @IKholopov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #21489: Fix broken tests after URL restructure PR
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #21489:
URL: https://github.com/apache/airflow/pull/21489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #21489: Fix broken tests after URL restructure PR
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #21489:
URL: https://github.com/apache/airflow/pull/21489#discussion_r803548113
##########
File path: airflow/utils/helpers.py
##########
@@ -258,8 +257,7 @@ def build_airflow_url_with_query(query: Dict[str, Any]) -> str:
import flask
view = conf.get('webserver', 'dag_default_view').lower()
- url = flask.url_for(f"Airflow.{view}")
- return f"{url}?{parse.urlencode(query)}"
+ return flask.url_for(f"Airflow.{view}", **query)
Review comment:
Turns out URL for handles url prams and everything else gets set as query params, so the fix was easy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21489: Fix broken tests after URL restructure PR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21489:
URL: https://github.com/apache/airflow/pull/21489#issuecomment-1034782390
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org