[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...

[haoch <gi...@git.apache.org>]

Github user haoch commented on the issue:

    https://github.com/apache/incubator-eagle/pull/556
  
    @garrettlish the implementation looks a little confusing.
    
    Please just simply use kafka configs: https://kafka.apache.org/08/documentation.html#clientconfig and another part using async kafka producer: https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/sink/KafkaStreamSink.java#L53-L57
    
    # kafka properties
    
        producer.type = async
        batch.num.messages = 3000
        queue.buffering.max.ms	= 5000
        queue.buffering.max.messages = 10000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---