You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/05 13:17:47 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #34844: GH-34843: [R] Fix R build failed caused by Acero refactor

westonpace commented on code in PR #34844:
URL: https://github.com/apache/arrow/pull/34844#discussion_r1158507833


##########
dev/tasks/homebrew-formulae/apache-arrow.rb:
##########
@@ -72,6 +72,7 @@ def install
     # link against system libc++ instead of llvm provided libc++
     ENV.remove "HOMEBREW_LIBRARY_PATHS", Formula["llvm"].opt_lib
     args = %W[
+      -DARROW_ACERO=ON

Review Comment:
   I'm not sure what the guidelines are.  R uses Acero directly, in addition to transitively through datasets.  So if R decided to stop using datasets then it would still need the acero dependency.  However, if we want to leave it out so things are concise then it should work.  I am fine either way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org