You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/07 23:40:18 UTC

[GitHub] [samza] shanthoosh opened a new pull request #1269: Validate the argument types in SamzaSQL UDF on execution planning phase

shanthoosh opened a new pull request #1269: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] srinipunuru edited a comment on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

Posted by GitBox <gi...@apache.org>.
srinipunuru edited a comment on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269#issuecomment-584396033
 
 
   @santhoshvenkat1988  Couple of things that you could look at in future
   
   1. If adding validations with UDF polymorphism is hard, We could disable/remove it.
   2. May be an end to end planning test UDf type validation test would be great.  
   3. Can you add description to the PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] shanthoosh commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

Posted by GitBox <gi...@apache.org>.
shanthoosh commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269#issuecomment-584432356
 
 
   Thanks for the review @srinipunuru 
   - I've updated the PR description.
   - I have added the end-to-end integration test for mismatched SamzaSQL UDF type.
   - Created a follow-up ticket to disallow the UDF polymorphism.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] shanthoosh commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

Posted by GitBox <gi...@apache.org>.
shanthoosh commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269#issuecomment-583662656
 
 
   @weiqingy Can you please take a look at this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] shanthoosh merged pull request #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

Posted by GitBox <gi...@apache.org>.
shanthoosh merged pull request #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] srinipunuru commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

Posted by GitBox <gi...@apache.org>.
srinipunuru commented on issue #1269: SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase
URL: https://github.com/apache/samza/pull/1269#issuecomment-584396033
 
 
   @santhoshvenkat1988  Couple of things that you could look at in future
   
   1. If adding validations with UDF polymorphism is hard, We could disable/remove it.
   2. May be an end to end planning test UDf type validation test would be great.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services