You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/15 03:13:51 UTC

[GitHub] [spark] yaooqinn commented on a change in pull request #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership

yaooqinn commented on a change in pull request #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership
URL: https://github.com/apache/spark/pull/26068#discussion_r334736514
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -573,8 +574,9 @@ private[hive] class HiveClientImpl(
     // If users explicitly alter these Hive-specific properties through ALTER TABLE DDL, we respect
     // these user-specified values.
     verifyColumnDataType(table.dataSchema)
+    val owner = Option(table.owner).filter(_.nonEmpty).getOrElse(userName)
 
 Review comment:
   It sounds like a bigger deal than it is. Indeed,  I am going to add `alter table owner` syntax, which may make this kind of change back and forth

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org