You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/19 06:15:43 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4364: decouple find IndexSegment with SQLStatement
terrymanu opened a new pull request #4364: decouple find IndexSegment with SQLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4364
For #4342.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4364:
decouple find IndexSegment with SQLStatement
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4364: decouple find IndexSegment with SQLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588062425
## Pull Request Test Coverage Report for [Build 9644](https://coveralls.io/builds/28817798)
* **12** of **12** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.007%**) to **57.359%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28817798/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L117) | 1 | 59.46% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28817798/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/28817798) |
| :-- | --: |
| Change from base [Build 880](https://coveralls.io/builds/28816932): | 0.007% |
| Covered Lines: | 11068 |
| Relevant Lines: | 19296 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4364:
decouple find IndexSegment with SQLStatement
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4364: decouple find IndexSegment with SQLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4364: decouple find IndexSegment with SQLStatement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4364: decouple find IndexSegment with SQLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588062425
## Pull Request Test Coverage Report for [Build 1806](https://coveralls.io/builds/28817800)
* **12** of **12** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.01%**) to **57.364%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28817800/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L117) | 1 | 59.46% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28817800) |
| :-- | --: |
| Change from base [Build 880](https://coveralls.io/builds/28816932): | 0.01% |
| Covered Lines: | 11069 |
| Relevant Lines: | 19296 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4364:
decouple find IndexSegment with SQLStatement
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4364: decouple find IndexSegment with SQLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588061068
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=h1) Report
> Merging [#4364](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6ce5057f10aa13129c070e10a1722ef15f461051?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4364 +/- ##
===========================================
+ Coverage 53.88% 53.9% +0.01%
Complexity 351 351
===========================================
Files 1047 1047
Lines 19288 19296 +8
Branches 3550 3553 +3
===========================================
+ Hits 10393 10401 +8
Misses 8238 8238
Partials 657 657
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rite/token/generator/impl/IndexTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5kZXhUb2tlbkdlbmVyYXRvci5qYXZh) | `100% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=footer). Last update [6ce5057...3b4d01e](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services