[GitHub] [helix] jiajunwang commented on a change in pull request #531: Make log clearer after finishing calculateAssignment.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #531: Make log clearer after finishing calculateAssignment.
URL: https://github.com/apache/helix/pull/531#discussion_r338393751
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -443,7 +443,7 @@ private void refreshBaseline(ResourceControllerDataProvider clusterData,
     Map<String, ResourceAssignment> newAssignment =
         optimalAssignment.getOptimalResourceAssignment();
 
-    LOG.info("Finish calculating. Time spent: {}ms.", System.currentTimeMillis() - startTime);
+    LOG.info("Finish calculateAssignment(). Took: {} ms.", System.currentTimeMillis() - startTime);
 
 Review comment:
   "Finish calculating assignment."
   Usually, we don't like pasting code details in the log. Consider what if we change the method name in the future?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org