You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/02 12:46:34 UTC
Review Request 40866: AMBARI-14153 : [Ranger's smart configs] Group
User Map Sync should not drive user attributes in usersync config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14153
https://issues.apache.org/jira/browse/AMBARI-14153
Repository: ambari
Description
-------
Patch contains :
1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6a85479
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 6b9b0a0
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
Diff: https://reviews.apache.org/r/40866/diff/
Testing
-------
Verified updated properties in Ambari UI for Ranger Configs.
-----------------------------------------------------------------------
Ran 271 tests in 8.151s
OK
----------------------------------------------------------------------
Total run:879
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40866: AMBARI-14153 : [Ranger's smart configs]
Group User
Map Sync should not drive user attributes in usersync config
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 2, 2015, 6:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, line 95
> > <https://reviews.apache.org/r/40866/diff/1/?file=1150509#file1150509line95>
> >
> > Doesn't this need to be present in the other upgrade packs?
> > 2.2->2.2*
> > 2.3->2.3*
Updated in latest patch
> On Dec. 2, 2015, 6:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml, line 343
> > <https://reviews.apache.org/r/40866/diff/1/?file=1150510#file1150510line343>
> >
> > Does this value need to be changed in config-upgrade.xml used by RU and EU from 2.2->2.3?
Handling this change in AMBARI-14169
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/#review108690
-----------------------------------------------------------
On Dec. 3, 2015, 7:18 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40866/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 7:18 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14153
> https://issues.apache.org/jira/browse/AMBARI-14153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains :
> 1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
> 2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 019dd5d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml e010632
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e75abfc
>
> Diff: https://reviews.apache.org/r/40866/diff/
>
>
> Testing
> -------
>
> Verified updated properties in Ambari UI for Ranger Configs.
>
> -----------------------------------------------------------------------
> Ran 271 tests in 8.151s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40866: AMBARI-14153 : [Ranger's smart configs]
Group User
Map Sync should not drive user attributes in usersync config
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/#review108690
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml (line 95)
<https://reviews.apache.org/r/40866/#comment168145>
Doesn't this need to be present in the other upgrade packs?
2.2->2.2*
2.3->2.3*
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml (line 343)
<https://reviews.apache.org/r/40866/#comment168148>
Does this value need to be changed in config-upgrade.xml used by RU and EU from 2.2->2.3?
- Alejandro Fernandez
On Dec. 2, 2015, 11:46 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40866/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 11:46 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14153
> https://issues.apache.org/jira/browse/AMBARI-14153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains :
> 1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
> 2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6a85479
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 6b9b0a0
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
>
> Diff: https://reviews.apache.org/r/40866/diff/
>
>
> Testing
> -------
>
> Verified updated properties in Ambari UI for Ranger Configs.
>
> -----------------------------------------------------------------------
> Ran 271 tests in 8.151s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40866: AMBARI-14153 : [Ranger's smart configs]
Group User
Map Sync should not drive user attributes in usersync config
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/#review108849
-----------------------------------------------------------
Hi Gautam, I would prefer if either AMBARI-14169 was combined into this one, or the config change was done in AMBARI-14169.
We're ramping down on Ambari 2.1.3 (now known as 2.2) so it's good to have atomic changes.
- Alejandro Fernandez
On Dec. 3, 2015, 7:18 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40866/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 7:18 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14153
> https://issues.apache.org/jira/browse/AMBARI-14153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains :
> 1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
> 2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 019dd5d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml e010632
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e75abfc
>
> Diff: https://reviews.apache.org/r/40866/diff/
>
>
> Testing
> -------
>
> Verified updated properties in Ambari UI for Ranger Configs.
>
> -----------------------------------------------------------------------
> Ran 271 tests in 8.151s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40866: AMBARI-14153 : [Ranger's smart configs]
Group User
Map Sync should not drive user attributes in usersync config
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/#review108848
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Dec. 3, 2015, 7:18 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40866/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 7:18 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14153
> https://issues.apache.org/jira/browse/AMBARI-14153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains :
> 1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
> 2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 019dd5d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml e010632
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e75abfc
>
> Diff: https://reviews.apache.org/r/40866/diff/
>
>
> Testing
> -------
>
> Verified updated properties in Ambari UI for Ranger Configs.
>
> -----------------------------------------------------------------------
> Ran 271 tests in 8.151s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40866: AMBARI-14153 : [Ranger's smart configs]
Group User
Map Sync should not drive user attributes in usersync config
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40866/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 7:18 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Handling Alejandro Fernandez comments
Bugs: AMBARI-14153
https://issues.apache.org/jira/browse/AMBARI-14153
Repository: ambari
Description
-------
Patch contains :
1. Setting ranger.usersync.group.usermapsyncenabled value to true by default.
2. Removed dependency of user parameters (in user configs tab) on group user map sync property.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 019dd5d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml e010632
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json db65e54
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e75abfc
Diff: https://reviews.apache.org/r/40866/diff/
Testing
-------
Verified updated properties in Ambari UI for Ranger Configs.
-----------------------------------------------------------------------
Ran 271 tests in 8.151s
OK
----------------------------------------------------------------------
Total run:879
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad