[GitHub] [cordova-plugin-media] mikhail-irdeto commented on a change in pull request #196: Add support for setRate on Android. Fix setRate on iOS when seeking.

[GitBox <gi...@apache.org>]

mikhail-irdeto commented on a change in pull request #196: Add support for setRate on Android. Fix setRate on iOS when seeking.
URL: https://github.com/apache/cordova-plugin-media/pull/196#discussion_r289722925
 
 

 ##########
 File path: www/Media.js
 ##########
 @@ -170,11 +170,7 @@ Media.prototype.setVolume = function(volume) {
  * Adjust the playback rate.
  */
 Media.prototype.setRate = function(rate) {
-    if (cordova.platformId === 'ios'){
-        exec(null, null, "Media", "setRate", [this.id, rate]);
-    } else {
-        console.warn('media.setRate method is currently not supported for', cordova.platformId, 'platform.');
-    }
+    exec(null, null, "Media", "setRate", [this.id, rate]);
 
 Review comment:
   This applies to all platforms now (incl. WP, still), however the actual support is only for iOS and Android, as far as I understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org