You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/12 21:48:25 UTC

[GitHub] [tvm] MargaretQian opened a new pull request, #10985: [ONNX] Sort axes for unsqueeze op

MargaretQian opened a new pull request, #10985:
URL: https://github.com/apache/tvm/pull/10985

   Looking at the onnx op documentation, it appears that the axes for unsqueeze are expected to be applied in sorted order: https://github.com/onnx/onnx/blob/main/docs/Operators.md#Unsqueeze
   
   Also, although tests are a bit slow, they're taking <5 min when I tried locally for non-llvm targets (cuda, opencl), so I'm uncommenting them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10985: [ONNX] Sort axes for unsqueeze op

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on PR #10985:
URL: https://github.com/apache/tvm/pull/10985#issuecomment-1098302603

   Awesome, more tests B)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] AndrewZhaoLuo merged pull request #10985: [ONNX] Sort axes for unsqueeze op

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged PR #10985:
URL: https://github.com/apache/tvm/pull/10985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] MargaretQian commented on pull request #10985: [ONNX] Sort axes for unsqueeze op

Posted by GitBox <gi...@apache.org>.
MargaretQian commented on PR #10985:
URL: https://github.com/apache/tvm/pull/10985#issuecomment-1097256591

   cc @anwang2009 @sfvaroglu @AndrewZhaoLuo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org