[GitHub] [hive] pkumarsinha commented on a change in pull request #1655: HIVE-24349: Client connection count is not printed correctly in HiveM…

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #1655:
URL: https://github.com/apache/hive/pull/1655#discussion_r525009064



##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -790,6 +790,9 @@ public void close() {
     try {
       if (null != client) {
         client.shutdown();
+        if ((transport == null) || !transport.isOpen()) {
+          LOG.info("Closed a connection to metastore, current connections: " + connCount.decrementAndGet());

Review comment:
       You can use substitution while logging like it  is in other place in method. If possible please add a test for counter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org