You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/21 12:55:09 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4068: Adding Centos8 Support

GabrielBrascher commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r428631368



##########
File path: python/bindir/cloud-grab-dependent-library-versions
##########
@@ -27,7 +27,7 @@ def runCmd(cmds):
     stdout, stderr = process.communicate()
     if process.returncode != 0:
         raise Exception(stderr)
-    return stdout
+    return stdout.decode('utf-8')

Review comment:
       On depLibraries I think that it would be necessary also to add python3.
   
   depLibraries = ['python', 'pythom3', ...]




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org