You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by giuseppelt <gi...@git.apache.org> on 2016/09/14 16:06:57 UTC
[GitHub] cordova-windows pull request #196: Fix setSplashBgColor exception when no sp...
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-windows/pull/196
Fix setSplashBgColor exception when no splashscreen is found
WindowsPhone allows to unset splashscreen (img) to avoid it to be shown.
This patch fixes whenever the "splashscreen" node is not present.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/giuseppelt/cordova-windows patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit 0d36e3fd782cd69798c65c57f39f0d4aaecb1717
Author: giuseppelt <gi...@users.noreply.github.com>
Date: 2016-09-14T16:06:25Z
Fix setSplashBgColor exception when no splashscreen is found
WindowsPhone allows to unset splashscreen (img) to avoid it to be shown.
This patch fixes whenever the "splashscreen" node is not present.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #196: Fix setSplashBgColor exception when no sp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by giuseppelt <gi...@git.apache.org>.
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
This patch doesn't touch nothing, nor alter the manifest.
It's just a logic check, because the previous code assumes the node is always found.
The code simply is `if (node != null) ...dologic` nothing more than that.
The assumption is wrong, because you can have a manifest (WP8.1) without splashscreen node.
Manifest without the splashscreen node: --> Exception.
Manifest with the node: --> run as usual.
This patch is just a logic check, no omission, no something else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by giuseppelt <gi...@git.apache.org>.
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Jira issue https://issues.apache.org/jira/browse/CB-12036 set as Minor.
But, please, don't delay because the missing feature. The issue is beyond that, the code is wrong because the assumption is false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
That link is for Windows Phone 8 while cordova-windows is for Windows 8.1 / Windows Phone 8.1 and up.
In general the patch could be applicable for Windows 10 appxmanifest as SplashScreen is not required for it: https://msdn.microsoft.com/en-us/library/windows/apps/dn934817.aspx
Omitting it results in a black window frame color though which I don't see a way to avoid - and it seems like an issue to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/196
@giuseppelt, is there a JIRA issue about this? It would be nice if you could create one with explanation of your usecase and attach it to this PR by specifying JIRA item title at the beginning of PR name.
@daserge, could you please elaborate how this causes problems with window frame color?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by giuseppelt <gi...@git.apache.org>.
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Schema is incorrect or old.
According to https://msdn.microsoft.com/en-us/library/windows/apps/ff769511(v=vs.105).aspx splashscreen isn't required nor it's provided in the default template.
> Windows Phone 8 apps load quickly, so a Windows Phone 8 app usually doesn\u2019t need a splash screen. New Windows Phone 8 projects don\u2019t include a default splash screen image file. However, if you want to use a splash screen in your Windows Phone 8 app, add an existing JPG image file to the root folder of your Windows Phone 8 project, and name the file SplashScreenImage.jpg.
Anyway the patch here, doesn't delete the element, but just avoid null-reference when the node isn't present, like in the default template.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/196
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/196?src=pr) is 74.25% (diff: 75.00%)
> Merging [#196](https://codecov.io/gh/apache/cordova-windows/pull/196?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
```diff
@@ master #196 diff @@
==========================================
Files 14 14
Lines 1942 1942
Methods 362 362
Messages 0 0
Branches 391 391
==========================================
Hits 1442 1442
Misses 500 500
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [0855feb...0d36e3f](https://codecov.io/gh/apache/cordova-windows/compare/0855feb13aa5de334d5a7cdedea646f31bf8ddfe...0d36e3fd782cd69798c65c57f39f0d4aaecb1717?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
@giuseppelt thanks for the contribution - the logic fix is valid, I was not disputing this.
This requires additional changes though because the [current windows template](https://github.com/apache/cordova-windows/blob/258a21dbf6ac4bd020e304de8544992e5e3cd9f2/template/package.phone.appxmanifest#L50) includes SplashScreen node and giving the platforms are considered build artifacts - the node removal should be available through the config.xml preference.
That preference would be then documented in the cordova-plugin-splashscreen along with the [Windows 10 quirk](https://github.com/apache/cordova-windows/pull/196#issuecomment-254519722).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Looks like SplashScreen node is required according to the [schema](https://msdn.microsoft.com/en-us/library/windows/apps/br211471.aspx).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org