[GitHub] [spark] LuciferYang commented on a diff in pull request #41491: [SPARK-43991][CORE] Use the value of spark.eventLog.compression.codec set by user when write compact file

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41491:
URL: https://github.com/apache/spark/pull/41491#discussion_r1222372233


##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileCompactor.scala:
##########
@@ -221,5 +222,19 @@ private class CompactedEventLogFileWriter(
     hadoopConf: Configuration)
   extends SingleEventLogFileWriter(appId, appAttemptId, logBaseDir, sparkConf, hadoopConf) {
 
-  override val logPath: String = originalFilePath.toUri.toString + EventLogFileWriter.COMPACTED
+  override val shouldCompress = EventLogFileWriter.codecName(originalFilePath) match {
+    case Some(_) => true
+    case _ => false
+  }

Review Comment:
   Equivalent to `EventLogFileWriter.codecName(originalFilePath).isDefined`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org