[GitHub] [pinot] walterddr commented on a diff in pull request #10564: [multistage] Add Callbacks for Complete Events

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10564:
URL: https://github.com/apache/pinot/pull/10564#discussion_r1169446932


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -148,6 +148,7 @@ public void onError(Throwable e) {
   @Override
   public void onCompleted() {
     _isCompleted.set(true);
+    _gotMailCallback.accept(_mailboxId);

Review Comment:
   shouldn't we also wake up onError as well. we need also to populate errors upstream?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org