[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

["Artem Ervits (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384144#comment-16384144 ] 

Artem Ervits commented on HBASE-19985:
--------------------------------------

[~appy] I was told to ping you, I'm trying to create a patch for this and I'm having issues as it says it's pulling 3800 commits as part of interactive rebase
{code:java}
HW12107:hbase aervits$ git checkout branch-1.4
Checking out files: 100% (4906/4906), done.
Branch 'branch-1.4' set up to track remote branch 'branch-1.4' from 'origin'.
Switched to a new branch 'branch-1.4'
HW12107:hbase aervits$ git checkout -B HBASE-19985
Switched to a new branch 'HBASE-19985'
HW12107:hbase aervits$ git add .
HW12107:hbase aervits$ git commit -a -m "HBASE-19985 Redundant instanceof check in ProtobufUtil#getServiceException"
[HBASE-19985 8d4c748edb] HBASE-19985 Redundant instanceof check in ProtobufUtil#getServiceException
1 file changed, 2 insertions(+), 5 deletions(-)
HW12107:hbase aervits$ dev-support/make_patch.sh
git_dirty is 0
Patch directory not specified. Falling back to ~/patches/.
3480 commits exist only in your local branch. Interactive rebase?{code}
please advise

> Redundant instanceof check in ProtobufUtil#getServiceException
> --------------------------------------------------------------
>
>                 Key: HBASE-19985
>                 URL: https://issues.apache.org/jira/browse/HBASE-19985
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Ted Yu
>            Assignee: Artem Ervits
>            Priority: Trivial
>             Fix For: 1.5.0, 1.4.3
>
>
> {code}
>   public static IOException getServiceException(ServiceException e) {
>     Throwable t = e;
>     if (e instanceof ServiceException) {
>       t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)