You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/10/11 03:34:51 UTC
Review Request 52725: GEODE-1801: Amended Logic to increment
nonSingleHopsCount
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52725/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
Amended the logic in the ClientMetadataService to more reliably increment the nonSingleHopsCount. This is done rather than amended each data Op that were to use it.
Seems to have vast amounts of formatting changes.
Code that has changed:
ClientMetadataService : scheduleGetPRMetaData. line 455 and 537
GemFireCacheImpl : getClientMetadataService. line 1970 moved the return clientMetadataService to outside the sync block
SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code blocks exact same implementation
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java c863d46
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java d166397
geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48
Diff: https://reviews.apache.org/r/52725/diff/
Testing
-------
Pre-checkin started
Thanks,
Udo Kohlmeyer
Re: Review Request 52725: GEODE-1801: Amended Logic to increment
nonSingleHopsCount
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52725/#review152162
-----------------------------------------------------------
I think it is very important not to do reformatting with other fixes.
I recommend that you redo this fix without the reformatting changes.
Reformatting should be done as a seperate ticket. If your IDE is configured
to do automatic reformatting it should be changed to not be automatic.
- Darrel Schneider
On Oct. 10, 2016, 8:34 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52725/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 8:34 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Amended the logic in the ClientMetadataService to more reliably increment the nonSingleHopsCount. This is done rather than amended each data Op that were to use it.
>
> Seems to have vast amounts of formatting changes.
> Code that has changed:
> ClientMetadataService : scheduleGetPRMetaData. line 455 and 537
> GemFireCacheImpl : getClientMetadataService. line 1970 moved the return clientMetadataService to outside the sync block
> SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code blocks exact same implementation
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java c863d46
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java d166397
> geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48
>
> Diff: https://reviews.apache.org/r/52725/diff/
>
>
> Testing
> -------
>
> Pre-checkin started
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 52725: GEODE-1801: Amended Logic to increment
nonSingleHopsCount
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52725/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 8:37 p.m.)
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Changes
-------
Amended class changes to reduce formatting diffs
Repository: geode
Description
-------
Amended the logic in the ClientMetadataService to more reliably increment the nonSingleHopsCount. This is done rather than amended each data Op that were to use it.
Seems to have vast amounts of formatting changes.
Code that has changed:
ClientMetadataService : scheduleGetPRMetaData. line 455 and 537
GemFireCacheImpl : getClientMetadataService. line 1970 moved the return clientMetadataService to outside the sync block
SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code blocks exact same implementation
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java c863d46
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java d166397
geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48
Diff: https://reviews.apache.org/r/52725/diff/
Testing
-------
Pre-checkin started
Thanks,
Udo Kohlmeyer