You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "TimCoder (via GitHub)" <gi...@apache.org> on 2023/10/10 01:30:50 UTC
[PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
TimCoder opened a new pull request, #25203:
URL: https://github.com/apache/doris/pull/25203
## Proposed changes
Update tpcds tools:
Fix the escape character '\' error in sql generated by tpcds tools scripts gen-tpcds-queries.sh
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1788551892
could u add a example to explain the behavior before and after this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "TimCoder (via GitHub)" <gi...@apache.org>.
TimCoder commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1754173394
when execute the query generated by gen-tpcds-queries.sh， the query with '\' failed. @englefly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1754166583
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/6463590354") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/tpcds-tools/bin/gen-tpcds-queries.sh line 151:
q="${q//${origin}/concat(concat('${smc1}', ','), '${smc2}')}" && echo "${q};" >>"${of}"
^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
For more information:
https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "TimCoder (via GitHub)" <gi...@apache.org>.
TimCoder commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1754168361
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #25203: [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts
URL: https://github.com/apache/doris/pull/25203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1803219457
这可能是系统兼容性原因吧，在我环境上ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1807386705
> #### `sh-checker report`
> To get the full details, please check in the job output.
>
> shellcheck errors
> ```
>
> 'shellcheck ' returned error 1 finding the following syntactical issues:
>
> ----------
>
> In tools/tpcds-tools/bin/gen-tpcds-queries.sh line 151:
> q="${q//${origin}/concat(concat('${smc1}', ','), '${smc2}')}" && echo "${q};" >>"${of}"
> ^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
> ^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
>
> For more information:
> https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...
> ----------
>
> You can address the above issues in one of three ways:
> 1. Manually correct the issue in the offending shell script;
> 2. Disable specific issues by adding the comment:
> # shellcheck disable=NNNN
> above the line that contains the issue, where NNNN is the error code;
> 3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
> ```
>
> shfmt errors
> ```
> 'shfmt ' found no issues.
> ```
Hi @TimCoder , you should fix the errors reported by the workflow.
By the way, did you run the script by `sh` (e.g. sh gen-tpcds-queries.sh) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "TimCoder (via GitHub)" <gi...@apache.org>.
TimCoder commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1803647211
> 这可能是系统兼容性原因吧，在我环境上ok
按这个commit中的代码修改后，是可以解决兼容性问题的，这个PR麻烦处理一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "TimCoder (via GitHub)" <gi...@apache.org>.
TimCoder commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1803089342
it seems different linux shell handle with '\' results different sql. the sql with '\' in left linux, doris ran will return error. @morrySnow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-1807383419
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/6844934365") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/tpcds-tools/bin/gen-tpcds-queries.sh line 151:
q="${q//${origin}/concat(concat('${smc1}', ','), '${smc2}')}" && echo "${q};" >>"${of}"
^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
^-------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
For more information:
https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25203:
URL: https://github.com/apache/doris/pull/25203#issuecomment-2106065422
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org