You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vijay Venkatachalam <vi...@citrix.com> on 2012/09/12 18:23:10 UTC
Review Request: AutoScale. Check vm group's interval during update with
existing policiy's duration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7057/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Deepak Garg.
Summary (updated)
-----------------
AutoScale. Check vm group's interval during update with existing policiy's duration
Description (updated)
-------
During update of Autoscale VM Group, checking if the vm group's interval is less than duration in existing policies'.
Also, correcting typo check on disabled state of vmgroup.
This addresses bug CS-15781.
Diffs (updated)
-----
server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097
Diff: https://reviews.apache.org/r/7057/diff/
Testing (updated)
-------
1. Create Vm Group (interval 30, policies duration 60) -> Disable Vm Group -> Update vm group with interval (interval 65). Error expected
Thanks,
Vijay Venkatachalam
Re: Review Request: AutoScale. Check vm group's interval during update with
existing policiy's duration
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7057/#review11733
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On Sept. 20, 2012, 11:40 a.m., Vijay Venkatachalam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7057/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 11:40 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Deepak Garg.
>
>
> Description
> -------
>
> During update of Autoscale VM Group, checking if the vm group's interval is less than duration in existing policies'.
> Also, correcting typo check on disabled state of vmgroup.
>
>
> This addresses bug CS-15781.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java ab8c452
>
> Diff: https://reviews.apache.org/r/7057/diff/
>
>
> Testing
> -------
>
> 1. Create Vm Group (interval 30, policies duration 60) -> Disable Vm Group -> Update vm group with interval (interval 65). Error expected
>
>
> Thanks,
>
> Vijay Venkatachalam
>
>
Re: Review Request: AutoScale. Check vm group's interval during update with
existing policiy's duration
Posted by Vijay Venkatachalam <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7057/
-----------------------------------------------------------
(Updated Sept. 20, 2012, 11:40 a.m.)
Review request for cloudstack, Devdeep Singh and Deepak Garg.
Changes
-------
Corrected the whitespace changes.
Description
-------
During update of Autoscale VM Group, checking if the vm group's interval is less than duration in existing policies'.
Also, correcting typo check on disabled state of vmgroup.
This addresses bug CS-15781.
Diffs (updated)
-----
server/src/com/cloud/network/as/AutoScaleManagerImpl.java ab8c452
Diff: https://reviews.apache.org/r/7057/diff/
Testing
-------
1. Create Vm Group (interval 30, policies duration 60) -> Disable Vm Group -> Update vm group with interval (interval 65). Error expected
Thanks,
Vijay Venkatachalam
Re: Review Request: AutoScale. Check vm group's interval during update with
existing policiy's duration
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7057/#review11528
-----------------------------------------------------------
server/src/com/cloud/network/as/AutoScaleManagerImpl.java
<https://reviews.apache.org/r/7057/#comment24775>
Just a nitpik, please correct the spacing and the brackets.
- Devdeep Singh
On Sept. 12, 2012, 4:23 p.m., Vijay Venkatachalam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7057/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 4:23 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Deepak Garg.
>
>
> Description
> -------
>
> During update of Autoscale VM Group, checking if the vm group's interval is less than duration in existing policies'.
> Also, correcting typo check on disabled state of vmgroup.
>
>
> This addresses bug CS-15781.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097
>
> Diff: https://reviews.apache.org/r/7057/diff/
>
>
> Testing
> -------
>
> 1. Create Vm Group (interval 30, policies duration 60) -> Disable Vm Group -> Update vm group with interval (interval 65). Error expected
>
>
> Thanks,
>
> Vijay Venkatachalam
>
>