You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/25 05:28:41 UTC
[GitHub] [camel-spring-boot] michaelandrepearce opened a new pull request #415: CAMEL-15560 - Fix regression
michaelandrepearce opened a new pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415
This fixes regression caused by removal of collectXmlRoutesFromDirectory methods, which overrode default to use spring's application context.
The fix basically implements new equivalent method, re-introducing loading resource by the applicationContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985988515
How are you packing your spring-boot apps - if its a fat-jar then the `FatJarPackageScanResourceResolver` should be the one that finds the files. Can you look into this. As your PR will due to code override not use that resolver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986099604
@davsclaus i had some free time this evening, as such created JIRA:
https://issues.apache.org/jira/browse/CAMEL-17274
Extracted sample application demonstrating the issue (not the app is set to 3.7.6 showing its working, but breaks when you upgrade to 3.8.0 or above), this is zipped and attached to JIRA ticket.
Amended commit message to new JIRA id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] mpoutlook commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
mpoutlook commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985986842
@davsclaus anything in addition needed? This is blocking upgrading to later versions of camel. Due to the break caused in 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce edited a comment on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986002786
No the fat jar resolver isnt picking up correctly, you have to use the spring context (as the code use to) and thus why once packaged with spring boot 3.8 it is broken. As the code overide that use to be there was just deleted not updated to the new method, which is what this pr fixes / puts back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce edited a comment on pull request #415: CAMEL-17274 - Fix regression caused by CAMEL-15560
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986099604
@davsclaus i had some free time this evening, as such created JIRA:
https://issues.apache.org/jira/browse/CAMEL-17274
Extracted sample application demonstrating the issue (note the app is set to 3.7.6 showing its working, but breaks when you upgrade to 3.8.0 or above), this is zipped and attached to JIRA ticket. Like wise if you apply the fix in this PR the regression is resolved.
Amended commit message to new JIRA id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus closed pull request #415: CAMEL-17274 - Fix regression caused by CAMEL-15560
Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986051289
We plan to cut 3.14 by end of next week, so it would be good to have this start of next week so time to make it into the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985988751
In other words your change may cause other problems, although it may be that spring application context can load resources inside fat-jars, which you may assume it can.
And if you have a sample project that reproduces this - that would help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985986992
@davsclaus anything in addition needed? This is blocking upgrading to later versions of camel. Due to the break caused in 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986055969
Ill get it done Monday when back in work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] mpoutlook removed a comment on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
mpoutlook removed a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985986842
@davsclaus anything in addition needed? This is blocking upgrading to later versions of camel. Due to the break caused in 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce edited a comment on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986002786
No the fat jar resolver isnt picking up correctly, you have to use the spring context (as the code use to) and thus why once packaged with spring boot 3.8 it is broken. As the code overide that use to be there was just deleted not updated to the new method, which is what this pr fixes / puts back but with updated logic/method to meet new method reqs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #415: CAMEL-17274 - Fix regression caused by CAMEL-15560
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986606874
Found another way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelpearce-gain commented on pull request #415: CAMEL-17274 - Fix regression caused by CAMEL-15560
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986771260
@davsclaus thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce edited a comment on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986002786
No the fat jar resolver isnt picking up correctly, you have to use the spring context (as the code use to) and thus why once packaged with spring 3.8 it is broken. As the code overide that use to be there was just deleted not updated to the new method, which is what this pr fixes / puts back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986002786
No the fat jar resolver isnt picking up correctly, you have to use the spring context (as the code use to) and thus why once packaged with spring 3.8 is broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986003822
Will zip up a sample spring boot app to demonstrate and attach to jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] michaelandrepearce edited a comment on pull request #415: CAMEL-17274 - Fix regression caused by CAMEL-15560
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-986099604
@davsclaus i had some free time this evening, as such created JIRA:
https://issues.apache.org/jira/browse/CAMEL-17274
Extracted sample application demonstrating the issue (note the app is set to 3.7.6 showing its working, but breaks when you upgrade to 3.8.0 or above), this is zipped and attached to JIRA ticket.
Amended commit message to new JIRA id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #415: CAMEL-15560 - Fix regression
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #415:
URL: https://github.com/apache/camel-spring-boot/pull/415#issuecomment-985989066
And create a new JIRA ticket about this, and in that you can link/refer to CAMEL-15560. And update your commit message to use the new JIRA number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org