You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Anatol Pomozov <an...@gmail.com> on 2014/12/29 14:19:22 UTC
ruby 2.2: check-swig-rb test fails
Hi
I am trying to compile/run 1.8.11 svn tests with recently released ruby
2.2 and ruby swig test fails. See the output below. Looking at
run-test.rb code I do not see anything obviously wrong.
Can anybody reproduce the same problem?
[anatol@argo subversion-1.8.11]$ make check-swig-rb
if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/libsvn_swig_ruby
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/../../../libsvn_*;
do if [ -n "$DYLD_LIBRARY_PATH" ]; then
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else
LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; \
cd /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby;
\
if [ "2" -eq 1 -a "2" -lt 9 ] ; then \
/usr/bin/ruby -I
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
\
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb
\
--verbose=normal; \
else \
/usr/bin/ruby -I
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
\
/home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb;
\
fi
Makefile:860: recipe for target 'check-swig-rb' failed
make: *** [check-swig-rb] Error 1
Re: ruby 2.2: check-swig-rb test fails
Posted by Anatol Pomozov <an...@gmail.com>.
Hi
On Mon, Dec 29, 2014 at 12:19 PM, Anatol Pomozov
<an...@gmail.com> wrote:
> Hi
>
> On Mon, Dec 29, 2014 at 5:19 AM, Anatol Pomozov
> <an...@gmail.com> wrote:
>> Hi
>>
>> I am trying to compile/run 1.8.11 svn tests with recently released ruby
>> 2.2 and ruby swig test fails. See the output below. Looking at
>> run-test.rb code I do not see anything obviously wrong.
>>
>> Can anybody reproduce the same problem?
>>
>>
>> [anatol@argo subversion-1.8.11]$ make check-swig-rb
>>
>> if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/libsvn_swig_ruby
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/../../../libsvn_*;
>> do if [ -n "$DYLD_LIBRARY_PATH" ]; then
>> LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else
>> LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; \
>> cd /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby;
>> \
>> if [ "2" -eq 1 -a "2" -lt 9 ] ; then \
>> /usr/bin/ruby -I
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
>> \
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb
>> \
>> --verbose=normal; \
>> else \
>> /usr/bin/ruby -I
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
>> \
>> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb;
>> \
>> fi
>> Makefile:860: recipe for target 'check-swig-rb' failed
>> make: *** [check-swig-rb] Error 1
>
>
> Ok, I tracked down the first problem with the tests. Ruby 2.2 updates
> test framework to test-unit 3.0.8
> https://github.com/test-unit/test-unit It is more complicated
> framework than it was in ruby 2.1. Among other things it uses
> TestCase.inherited() method to collect all test cases
> https://github.com/test-unit/test-unit/blob/master/lib/test/unit/testcase.rb#L106
>
> Unfortunately svn tests override this method with its own
> implementation in test-unit-ext/priority.rb If I comment out 'require
> priority' part it allows me to load and run test. Some of the tests
> are failing and probably represent real issues with ruby 2.2. Here is
> the output https://gist.github.com/anatol/ba3ca9686c89cc7168a2
As it turned out the rest of ruby 2.2 failures are also test framework
API changes related: "assert_*" functions are void now and do not
return bool flag. But a few places in ruby swig tests assumes that
assert_* returns test result (passed or not) - and it causes test
failure.
Re: ruby 2.2: check-swig-rb test fails
Posted by Anatol Pomozov <an...@gmail.com>.
Hi
On Mon, Dec 29, 2014 at 5:19 AM, Anatol Pomozov
<an...@gmail.com> wrote:
> Hi
>
> I am trying to compile/run 1.8.11 svn tests with recently released ruby
> 2.2 and ruby swig test fails. See the output below. Looking at
> run-test.rb code I do not see anything obviously wrong.
>
> Can anybody reproduce the same problem?
>
>
> [anatol@argo subversion-1.8.11]$ make check-swig-rb
>
> if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/libsvn_swig_ruby
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/../../../libsvn_*;
> do if [ -n "$DYLD_LIBRARY_PATH" ]; then
> LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else
> LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; \
> cd /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby;
> \
> if [ "2" -eq 1 -a "2" -lt 9 ] ; then \
> /usr/bin/ruby -I
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
> \
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb
> \
> --verbose=normal; \
> else \
> /usr/bin/ruby -I
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby
> \
> /home/anatol/sources/core-arch/subversion/trunk/src/subversion-1.8.11/subversion/bindings/swig/ruby/test/run-test.rb;
> \
> fi
> Makefile:860: recipe for target 'check-swig-rb' failed
> make: *** [check-swig-rb] Error 1
Ok, I tracked down the first problem with the tests. Ruby 2.2 updates
test framework to test-unit 3.0.8
https://github.com/test-unit/test-unit It is more complicated
framework than it was in ruby 2.1. Among other things it uses
TestCase.inherited() method to collect all test cases
https://github.com/test-unit/test-unit/blob/master/lib/test/unit/testcase.rb#L106
Unfortunately svn tests override this method with its own
implementation in test-unit-ext/priority.rb If I comment out 'require
priority' part it allows me to load and run test. Some of the tests
are failing and probably represent real issues with ruby 2.2. Here is
the output https://gist.github.com/anatol/ba3ca9686c89cc7168a2