[GitHub] [cassandra] dcapwell commented on a diff in pull request #2241: CASSANDRA-18355 Avoid serializing full TxnData instances to Accord state tables

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on code in PR #2241:
URL: https://github.com/apache/cassandra/pull/2241#discussion_r1146847221


##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -652,8 +646,9 @@ public static Command loadCommand(AccordCommandStore commandStore, TxnId txnId)
                     return Command.SerializerSupport.committed(attributes, status, executeAt, promised, accepted, waitingOnCommit, waitingOnApply);
                 case PreApplied:
                 case Applied:
+                    return Command.SerializerSupport.executed(attributes, status, executeAt, promised, accepted, waitingOnCommit, waitingOnApply, writes, Result.APPLIED);

Review Comment:
   `org.apache.cassandra.service.accord.AccordObjectSizes#command` needs to be updated right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org