You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/02/25 18:29:33 UTC
[PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
liuxiaocs7 opened a new pull request, #7803:
URL: https://github.com/apache/hbase/pull/7803
- see: HBASE-29921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876477917
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
https://github.com/apache/hbase/pull/7592 also tried to solve this, we should close the other ticket if this change goes in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2869602002
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
We use `NotThreadSafe` annotation only in `BuiltInProviderSelector` under `hbase-client`
`InMemoryProviderSelector` in `hbase-server` extends `BuiltInProviderSelector`, we need to add this dependency to `hbase-server`
But a little strange `hbase-examples` can pass compile because `ShadeProviderSelector` extends `BuiltInProviderSelector` too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-3976156040
@Apache9, could you help re-trigger the failed `large-wave-1` and `large-wave-3`, failed ut can pass locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2869602002
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
We use `NotThreadSafe` annotation only in `BuiltInProviderSelector` under `hbase-client`
`InMemoryProviderSelector` in `hbase-server` extends `BuiltInProviderSelector`, we need to add this dependency to `hbase-server`
But a little strange `hbase-examples` can pass compile because `ShadeProviderSelector` extends `BuiltInProviderSelector` too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876501808
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
Maybe we should merge https://github.com/apache/hbase/pull/7592 and then just a simple hadoop bump here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4038969303
> > Thank you @liuxiaocs7 for all your effort, #7592 is merged, we can rebase. I will merge on other branches in some time.
>
> Hi @liuxiaocs7 [HBASE-29807](https://issues.apache.org/jira/browse/HBASE-29807) is merged to all branches, we can get this in now.
All branches have been completed
Failed UT in this PR(https://github.com/apache/hbase/actions/runs/22889276514/job/66604414565?pr=7803) will be resolved by https://github.com/apache/hbase/pull/7897 I think.
<img width="2090" height="312" alt="image" src="https://github.com/user-attachments/assets/4167714c-8bc7-4e1f-9b17-5e6d87a25fde" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4045610332
`TestSecureExportSnapshot` is flaky
<img width="2690" height="632" alt="image" src="https://github.com/user-attachments/assets/506f7fc5-6794-4cb5-8c5b-5b260af6f6c6" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4038849019
> > Thank you @liuxiaocs7 for all your effort, #7592 is merged, we can rebase. I will merge on other branches in some time.
>
> Hi @liuxiaocs7 [HBASE-29807](https://issues.apache.org/jira/browse/HBASE-29807) is merged to all branches, we can get this in now.
Hi, @NihalJain, thanks for reminding, let me continue work for other branches!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-3990113189
wait https://github.com/apache/hbase/pull/7592 merge first cc @NihalJain and @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4061318489
Failed Tests seems all unrelated, this bump seems OK, @Apache9, any more concerns in your side, thanks!
BTW, seems some uts fails on branch-2.5 for a long time, for example HBASE-30000
- [master](https://github.com/apache/hbase/pull/7803): `TestSecureExportSnapshot`
- [branch-3](https://github.com/apache/hbase/pull/7805): `TestSecureExportSnapshot`
- [branch-2](https://github.com/apache/hbase/pull/7806): `TestSecureExportSnapshot` and `TestMobSecureExportSnapshot`
- [branch-2.6](https://github.com/apache/hbase/pull/7807): `TestSecureExportSnapshot` and `TestMobSecureExportSnapshot`
- [branch-2.5](https://github.com/apache/hbase/pull/7808): `TestCompaction.testCompactionWithCorruptBlock`, `TestCompactionWithCoprocessor.testCompactionWithCorruptBlock`, `TestBasicWALEntryStreamAsyncFSWAL.testCleanClosedWALs`, `TestStochasticLoadBalancerRegionReplicaWithRacks.testRegionReplicationOnLargeClusterWithRacks`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876490997
##########
hbase-server/pom.xml:
##########
@@ -194,6 +194,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
why is this needed? the other PR did not need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-3991132898
Spend some time on jenkinsfile. Let me see If I can merge #7592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2869602002
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
We use `NotThreadSafe` annotation only in `BuiltInProviderSelector` under `hbase-client`
`InMemoryProviderSelector` in `hbase-server` extends `BuiltInProviderSelector`, we need to add this dependency to `hbase-server`
But a little strange `hbase-examples` can pass compile because `ShadeProviderSelector` extends `BuiltInProviderSelector` too...
<img width="720" height="350" alt="Image" src="https://github.com/user-attachments/assets/58c13924-4769-41e4-bd11-d29b5e8f77b6" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 closed pull request #7803: HBASE-29921 Bump default hadoop 3 version to 3.4.3
URL: https://github.com/apache/hbase/pull/7803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876482329
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
> Issue : HBase build fails with latest Hadoop versions due to missing net.jcip.annotations package.
Earlier hadoop was dependent on com.nimbusds:nimbus-jose-jwt:jar:9.37.2 (which brought in com.github.stephenc.jcip:jcip-annotations:jar:1.0-1).
>
> With latest hadoop: it has moved to com.nimbusds:nimbus-jose-jwt:jar:10.0.2 (which does not bring in the dependency), refer commit https://github.com/apache/hadoop/commit/3baa288982333fbbc3839cf55baaf36f49e0f7b6#diff-635a9ebcc70f58d8ca1c55b0d78cc90064a5081d189162a432271778da3cf018.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2877698952
##########
hbase-server/pom.xml:
##########
@@ -194,6 +194,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
@xavifeds8 could you confirm this on your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 merged PR #7803:
URL: https://github.com/apache/hbase/pull/7803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2869256607
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
Why we need this dependency only in hase-client and hbase-server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4028752349
Thank you @liuxiaocs7 for all your effort, https://github.com/apache/hbase/pull/7592 is merged, we can rebase. I will merge on other branches in some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4038071512
Seems need re-run `large-wave-3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876490997
##########
hbase-server/pom.xml:
##########
@@ -194,6 +194,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
why is this needed? AFAIC the other PR did not need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876543531
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
> Maybe we should merge #7592 and then just a simple hadoop bump here?
Hi, @NihalJain, thanks for pointing this, agree with your suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4038472784
> Thank you @liuxiaocs7 for all your effort, #7592 is merged, we can rebase. I will merge on other branches in some time.
Hi @liuxiaocs7 HBASE-29807 is merged to all branches, we can get this in now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876488978
##########
hbase-client/pom.xml:
##########
@@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
also review from copilot in other PR
> The groupId used here (com.github.stephenc.jcip) is inconsistent with the groupId referenced in supplemental-models.xml (net.jcip). This inconsistency could lead to confusion about which artifact is actually being used. Ensure that the groupId matches what's declared in the root pom.xml's dependencyManagement section, and consider whether both need to align with the existing supplemental-models.xml entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7803:
URL: https://github.com/apache/hbase/pull/7803#discussion_r2876566801
##########
hbase-server/pom.xml:
##########
@@ -194,6 +194,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review Comment:
seems `hbase-server` module will not pass the compile without this dependency in my local env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4024986629
It seems to be the same content as in https://github.com/apache/hbase/pull/7592 at last
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29921 Bump default hadoop 3 version to 3.4.3 [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7803:
URL: https://github.com/apache/hbase/pull/7803#issuecomment-4028911317
> Thank you @liuxiaocs7 for all your effort, #7592 is merged, we can rebase. I will merge on other branches in some time.
Hi, @NihalJain, Thanks for the reminder. I have already rebased the latest code. Let's wait for CI to pass, works for other branch will start once this code in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org