回复:Re: New Fetatures Discussion

[zcq <zc...@zhucongqi.cn>]

Hi,
1. the signer means sign worker or job, it's short.absolutely, modify it.
2. request id maybe follow and report application error or exception. ref aliyun. the "DefaultShenyuResult" contains, users can custom "ShenyuResult" turn off, and use the "org.apache.shenyu.plugin.api.request.id.ShenyuRequestIdWrap#getRequestId" API at any time to get the request id anywhere in the application.

--------------原始邮件--------------
发件人："XiaoYu "<xiaoyu@apache.org&gt;;
发送时间：2021年9月7日(星期二) 上午9:56
收件人："dev" <dev@shenyu.apache.org&gt;;
主题：Re: New Fetatures Discussion
-----------------------------------

 Hi

1. The signer maybe a good idea？ But Can you give it a good name?&nbsp; such as
SignAlgorithm?
2.&nbsp; The&nbsp; request id plugin Is there really a need for it to exist? To be
generated for every request? Can users turn it off dynamically?


zcq <zcq@zhucongqi.cn&gt; 于2021年9月7日周二 上午8:08写道：

&gt; Hi bros:
&gt;
&gt;
&gt; Recently, I provides three&amp;nbsp;features : custom the sign plugin signer,
&gt; request id plugin and detect real error codes instead of all using 500.
&gt;
&gt;
&gt; There are two options for sign plugin,&amp;nbsp;one is custom the SignService,
&gt; another is custom&amp;nbsp;the Signer.&amp;nbsp; Custom the signer is just replace
&gt; the "org.apache.shenyu.common.utils.SignUtils#generateSign", user can use
&gt; another algorithm, such as sha1, sha256 etc.
&gt;
&gt;
&gt;
&gt; see : https://github.com/apache/incubator-shenyu/pull/2021
&gt;
&gt;
&gt; The request id plugin will generate a id for every request. the id will
&gt; put to request header and response header, so the downstream can fetch
&gt; request id from request header, the frontend can fetch request id from
&gt; response header. use the org.apache.shenyu.plugin.api.request.id.ShenyuRequestIdWrap#getRequestId
&gt; API at any time to get the request id anywhere in the application.
&gt;
&gt;
&gt; request id plugin and detect real error codes see:&amp;nbsp;
&gt; https://github.com/apache/incubator-shenyu/pull/2027
&gt;
&gt;
&gt; How about the features?
&gt;
&gt;
&gt; thanks.