[GitHub] [samza] shanthoosh commented on a change in pull request #956: SAMZA-2132: Flatten startpoint key when serialized.

[GitBox <gi...@apache.org>]

shanthoosh commented on a change in pull request #956: SAMZA-2132: Flatten startpoint key when serialized.
URL: https://github.com/apache/samza/pull/956#discussion_r266721395
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/startpoint/StartpointKey.java
 ##########
 @@ -41,12 +41,29 @@
     this.taskName = taskName;
   }
 
+  @JsonIgnore
 
 Review comment:
   The idea of including only relevant fields from `StartpointKey` to reduce redundancy is a good one. 
   
   However, rather than marking individual fields in model POJO as included or not, it would be better to have a custom `JsonSerializer` implementation and have this logic to include fields we want in it. Similar to [SystemStreamPartitionSerializer](https://github.com/apache/samza/blob/master/samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java#L203)
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services