You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (Created) (JIRA)" <ji...@apache.org> on 2012/04/12 18:09:21 UTC

[jira] [Created] (THRIFT-1565) Thrift/cpp: Use default constructor for strings

Thrift/cpp: Use default constructor for strings

------------------------------------------------

                 Key: THRIFT-1565
                 URL: https://issues.apache.org/jira/browse/THRIFT-1565
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
            Reporter: Dave Watson
            Priority: Minor
         Attachments: 0007-Thrift-cpp-Use-default-constructor-for-strings.patch

>From 77bcf8958cfdb9032d62d8b42c1a919f273a5a7f Mon Sep 17 00:00:00 2001
From: David Reiss <dr...@fb.com>
Date: Fri, 10 Sep 2010 04:01:49 +0000
Subject: [PATCH 07/12] Thrift/cpp: Use default constructor for strings

Summary:
Using the char* constructor doesn't have any benefit that I can
determine.  Using the default constructor might even be a little faster.
Plus it will simplify an upcoming diff.

Test Plan:
Built some code.

DiffCamp Revision: 155271
Commenters: aalexandre
CC: dreiss, aalexandre, nschrenk, thrift-team@lists
Revert Plan:
ok

git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@37640 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
---
 compiler/cpp/src/generate/t_cpp_generator.cc |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (THRIFT-1565) Thrift/cpp: Use default constructor for strings

Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1565.
---------------------------------

    Resolution: Fixed
      Assignee: Dave Watson

committed
                
> Thrift/cpp: Use default constructor for strings

> ------------------------------------------------
>
>                 Key: THRIFT-1565
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1565
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>         Attachments: 0007-Thrift-cpp-Use-default-constructor-for-strings.patch
>
>
> From 77bcf8958cfdb9032d62d8b42c1a919f273a5a7f Mon Sep 17 00:00:00 2001
> From: David Reiss <dr...@fb.com>
> Date: Fri, 10 Sep 2010 04:01:49 +0000
> Subject: [PATCH 07/12] Thrift/cpp: Use default constructor for strings
> Summary:
> Using the char* constructor doesn't have any benefit that I can
> determine.  Using the default constructor might even be a little faster.
> Plus it will simplify an upcoming diff.
> Test Plan:
> Built some code.
> DiffCamp Revision: 155271
> Commenters: aalexandre
> CC: dreiss, aalexandre, nschrenk, thrift-team@lists
> Revert Plan:
> ok
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@37640 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1565) Thrift/cpp: Use default constructor for strings

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253442#comment-13253442 ] 

Hudson commented on THRIFT-1565:
--------------------------------

Integrated in Thrift #437 (See [https://builds.apache.org/job/Thrift/437/])
    THRIFT-1565 Thrift/cpp: Use default constructor for strings
Patch: Dave Watson (Revision 1325785)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1325785
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc

                
> Thrift/cpp: Use default constructor for strings

> ------------------------------------------------
>
>                 Key: THRIFT-1565
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1565
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>         Attachments: 0007-Thrift-cpp-Use-default-constructor-for-strings.patch
>
>
> From 77bcf8958cfdb9032d62d8b42c1a919f273a5a7f Mon Sep 17 00:00:00 2001
> From: David Reiss <dr...@fb.com>
> Date: Fri, 10 Sep 2010 04:01:49 +0000
> Subject: [PATCH 07/12] Thrift/cpp: Use default constructor for strings
> Summary:
> Using the char* constructor doesn't have any benefit that I can
> determine.  Using the default constructor might even be a little faster.
> Plus it will simplify an upcoming diff.
> Test Plan:
> Built some code.
> DiffCamp Revision: 155271
> Commenters: aalexandre
> CC: dreiss, aalexandre, nschrenk, thrift-team@lists
> Revert Plan:
> ok
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@37640 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1565) Thrift/cpp: Use default constructor for strings

Posted by "Dave Watson (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Watson updated THRIFT-1565:
--------------------------------

    Attachment: 0007-Thrift-cpp-Use-default-constructor-for-strings.patch
    
> Thrift/cpp: Use default constructor for strings

> ------------------------------------------------
>
>                 Key: THRIFT-1565
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1565
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Priority: Minor
>         Attachments: 0007-Thrift-cpp-Use-default-constructor-for-strings.patch
>
>
> From 77bcf8958cfdb9032d62d8b42c1a919f273a5a7f Mon Sep 17 00:00:00 2001
> From: David Reiss <dr...@fb.com>
> Date: Fri, 10 Sep 2010 04:01:49 +0000
> Subject: [PATCH 07/12] Thrift/cpp: Use default constructor for strings
> Summary:
> Using the char* constructor doesn't have any benefit that I can
> determine.  Using the default constructor might even be a little faster.
> Plus it will simplify an upcoming diff.
> Test Plan:
> Built some code.
> DiffCamp Revision: 155271
> Commenters: aalexandre
> CC: dreiss, aalexandre, nschrenk, thrift-team@lists
> Revert Plan:
> ok
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@37640 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira